Re: [PATCH 3/3] nfnetlink_queue: use hash table to speed up entry finding.

[Patrick McHardy <kaber@trash.net>]

Changli Gao wrote:
> On Thu, Apr 15, 2010 at 10:46 PM, Patrick McHardy <kaber@trash.net> wrote:
>> Patrick McHardy wrote:
>>> That should be easily fixable. For the lookup we can add a reference
>>> counter so we don't need the rcu read side critical section.
>> Actually we don't even need that, since we're holding nfnl_mutex the
>> instance can't go away.
>>
> 
> I don't think so. a netlink queue instance maybe destroyed by
> nfqnl_rcv_nl_event(). And the function is called by netlink directly
> without nfnl_mutex.

No its not:

static void nfnetlink_rcv(struct sk_buff *skb)
{
	nfnl_lock();
	netlink_rcv_skb(skb, &nfnetlink_rcv_msg);
	nfnl_unlock();
}