All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Bruce Rogers <brogers@novell.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using -device parm
Date: Wed, 14 Apr 2010 09:24:10 +0200	[thread overview]
Message-ID: <4BC56D9A.7010606@redhat.com> (raw)
In-Reply-To: <4BC482850200004800092E82@sinclair.provo.novell.com>

   Hi,

> When specifying ide devices using -device, the cmos information
> which the bios depends on is not written. This patch generalizes
> the cmos hd data setting for the existing code path and adds the
> ability to call that code on a per machine, per ide drive basis.

Hmm.

With -device and thus alot of device setup happening after 
QEMUMachine->init() I think it would be very useful to have 
QEMUMachine->init_late().  There are a bunch of machine specific jobs 
which need to be done after all devices have been plugged into the machine.

Setting up cmos is one of them.

i440fx_init_memory_mappings() could be moved there, which would allow to 
add vga cards via -device.

And I'm pretty sure there are more use cases.  fw_cfg maybe?

Comments?

cheers,
   Gerd

  reply	other threads:[~2010-04-14  9:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-13 20:41 [Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using -device parm Bruce Rogers
2010-04-14  7:24 ` Gerd Hoffmann [this message]
2010-04-19 20:04   ` Bruce Rogers
2010-04-20  7:28     ` Gerd Hoffmann
2010-05-03 18:24       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BC56D9A.7010606@redhat.com \
    --to=kraxel@redhat.com \
    --cc=brogers@novell.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.