All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Bruce Rogers <brogers@novell.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] Write cmos hd data for ide drives	 using -device parm
Date: Tue, 20 Apr 2010 09:28:22 +0200	[thread overview]
Message-ID: <4BCD5796.1030502@redhat.com> (raw)
In-Reply-To: <4BCC63030200004800093962@sinclair.provo.novell.com>

   Hi,

> Not much traffic on this thread ;-)

Indeed ;)

> I can see the usefulness of an init_late() to generalize post device setup issues.
> I assume then that you didn't have any other issues with my patch, other than general code structure concerns?

Yes, that is the major one.  I think it is much saner to just have a 
init_late() and collect everything there instead of creating a new hook 
each time you figure you need one.

I think this also allows to make the ide changes less intrusive as all 
the cmos setup logic stays local to pc.c.  pc.c can simply keep a 
pointer to the DeviceState structs of the ide interface(s) created in 
pc_init1().  pc_init_late() then can check which drives are plugged in 
and update cmos accordingly.

cheers,
   Gerd

  reply	other threads:[~2010-04-20  7:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-13 20:41 [Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using -device parm Bruce Rogers
2010-04-14  7:24 ` Gerd Hoffmann
2010-04-19 20:04   ` Bruce Rogers
2010-04-20  7:28     ` Gerd Hoffmann [this message]
2010-05-03 18:24       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCD5796.1030502@redhat.com \
    --to=kraxel@redhat.com \
    --cc=brogers@novell.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.