From: Roger Quadros <roger.quadros@nokia.com>
To: "Valkeinen Tomi (Nokia-D/Helsinki)" <Tomi.Valkeinen@nokia.com>
Cc: "tony@atomide.com" <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCHv2 0/5] OMAP: RX51: Add LCD Panel Support for N900
Date: Thu, 15 Apr 2010 10:04:01 +0000 [thread overview]
Message-ID: <4BC6E491.2020308@nokia.com> (raw)
In-Reply-To: <1271325104.2690.232.camel@tubuntu.research.nokia.com>
Hi,
Valkeinen Tomi (Nokia-D/Helsinki) wrote:
> Hi,
>
> On Thu, 2010-04-08 at 14:21 +0200, Quadros Roger (Nokia-D/Helsinki)
> wrote:
>> Tomi,
>>
>> Please take these in your DSS branch if they are OK.
>> Tony is fine if you take the board stuff too.
>
> checkpatch complained about using spaces for indenting. Can you check
> the patches?
I did check before sending. Anyways I will recheck and resend.
I also have some more fixes to the patchset
1) setting default_bpp in panel driver to 16. with SDI it takes it as 24 by default.
2) Add video memory allocation at board init.
There seems to be a TSC2005 driver floating around. So I will remove the patch
which introduces TSC2005 SPI info in board-file from my patchset to avoid
possible merge conflicts in future.
I will include these fixes in v3.
cheers,
-roger
>>
>> These patches get the N900 LCD panel working.
>> Apply's cleanly on 2.6.34-rc3
>>
>> Pre-requisites:
>> https://patchwork.kernel.org/patch/86318/
>> https://patchwork.kernel.org/patch/86319/
>> https://patchwork.kernel.org/patch/86320/
>>
>> Changes since v1:
>> -Added Backlight control
>>
>> ---
>> Roger Quadros (5):
>> OMAP: RX51: Add LCD Panel support
>> OMAP: RX51: Add "vdds_sdi" supply voltage for SDI
>> OMAP: RX51: Add Touch Controller in SPI board info
>> OMAP: DSS2: Add ACX565AKM Panel Driver
>> OMAP: RX51: Update board defconfig
>>
>> arch/arm/configs/rx51_defconfig | 39 ++-
>> arch/arm/mach-omap2/Makefile | 1 +
>> arch/arm/mach-omap2/board-rx51-peripherals.c | 43 ++
>> arch/arm/mach-omap2/board-rx51-video.c | 95 +++
>> drivers/video/omap2/displays/Kconfig | 6 +
>> drivers/video/omap2/displays/Makefile | 1 +
>> drivers/video/omap2/displays/panel-acx565akm.c | 819 ++++++++++++++++++++++++
>> 7 files changed, 1003 insertions(+), 1 deletions(-)
>> create mode 100644 arch/arm/mach-omap2/board-rx51-video.c
>> create mode 100644 drivers/video/omap2/displays/panel-acx565akm.c
>>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <roger.quadros@nokia.com>
To: "Valkeinen Tomi (Nokia-D/Helsinki)" <Tomi.Valkeinen@nokia.com>
Cc: "tony@atomide.com" <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCHv2 0/5] OMAP: RX51: Add LCD Panel Support for N900
Date: Thu, 15 Apr 2010 13:04:01 +0300 [thread overview]
Message-ID: <4BC6E491.2020308@nokia.com> (raw)
In-Reply-To: <1271325104.2690.232.camel@tubuntu.research.nokia.com>
Hi,
Valkeinen Tomi (Nokia-D/Helsinki) wrote:
> Hi,
>
> On Thu, 2010-04-08 at 14:21 +0200, Quadros Roger (Nokia-D/Helsinki)
> wrote:
>> Tomi,
>>
>> Please take these in your DSS branch if they are OK.
>> Tony is fine if you take the board stuff too.
>
> checkpatch complained about using spaces for indenting. Can you check
> the patches?
I did check before sending. Anyways I will recheck and resend.
I also have some more fixes to the patchset
1) setting default_bpp in panel driver to 16. with SDI it takes it as 24 by default.
2) Add video memory allocation at board init.
There seems to be a TSC2005 driver floating around. So I will remove the patch
which introduces TSC2005 SPI info in board-file from my patchset to avoid
possible merge conflicts in future.
I will include these fixes in v3.
cheers,
-roger
>>
>> These patches get the N900 LCD panel working.
>> Apply's cleanly on 2.6.34-rc3
>>
>> Pre-requisites:
>> https://patchwork.kernel.org/patch/86318/
>> https://patchwork.kernel.org/patch/86319/
>> https://patchwork.kernel.org/patch/86320/
>>
>> Changes since v1:
>> -Added Backlight control
>>
>> ---
>> Roger Quadros (5):
>> OMAP: RX51: Add LCD Panel support
>> OMAP: RX51: Add "vdds_sdi" supply voltage for SDI
>> OMAP: RX51: Add Touch Controller in SPI board info
>> OMAP: DSS2: Add ACX565AKM Panel Driver
>> OMAP: RX51: Update board defconfig
>>
>> arch/arm/configs/rx51_defconfig | 39 ++-
>> arch/arm/mach-omap2/Makefile | 1 +
>> arch/arm/mach-omap2/board-rx51-peripherals.c | 43 ++
>> arch/arm/mach-omap2/board-rx51-video.c | 95 +++
>> drivers/video/omap2/displays/Kconfig | 6 +
>> drivers/video/omap2/displays/Makefile | 1 +
>> drivers/video/omap2/displays/panel-acx565akm.c | 819 ++++++++++++++++++++++++
>> 7 files changed, 1003 insertions(+), 1 deletions(-)
>> create mode 100644 arch/arm/mach-omap2/board-rx51-video.c
>> create mode 100644 drivers/video/omap2/displays/panel-acx565akm.c
>>
>
>
next prev parent reply other threads:[~2010-04-15 10:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 12:21 [PATCHv2 0/5] OMAP: RX51: Add LCD Panel Support for N900 Roger Quadros
2010-04-08 12:21 ` Roger Quadros
2010-04-08 12:21 ` [PATCHv2 1/5] OMAP: RX51: Add LCD Panel support Roger Quadros
2010-04-08 12:21 ` Roger Quadros
2010-04-08 12:21 ` [PATCHv2 2/5] OMAP: RX51: Add "vdds_sdi" supply voltage for SDI Roger Quadros
2010-04-08 12:21 ` Roger Quadros
2010-04-08 12:21 ` [PATCHv2 3/5] OMAP: RX51: Add Touch Controller in SPI board info Roger Quadros
2010-04-08 12:21 ` Roger Quadros
2010-04-08 12:21 ` [PATCHv2 4/5] OMAP: DSS2: Add ACX565AKM Panel Driver Roger Quadros
2010-04-08 12:21 ` Roger Quadros
2010-04-08 12:21 ` [PATCHv2 5/5] OMAP: RX51: Update board defconfig Roger Quadros
2010-04-08 12:21 ` Roger Quadros
2010-04-15 9:51 ` [PATCHv2 0/5] OMAP: RX51: Add LCD Panel Support for N900 Tomi Valkeinen
2010-04-15 9:51 ` Tomi Valkeinen
2010-04-15 10:04 ` Roger Quadros [this message]
2010-04-15 10:04 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC6E491.2020308@nokia.com \
--to=roger.quadros@nokia.com \
--cc=Tomi.Valkeinen@nokia.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.