From: Jim Fehlig <jfehlig@novell.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] tools/hotplug/Linux/blktap: remove optional tapdisk: prefix
Date: Fri, 16 Apr 2010 14:51:22 -0600 [thread overview]
Message-ID: <4BC8CDCA.1000703@novell.com> (raw)
In-Reply-To: <4BC8547A020000780003A98D@vpn.id2.novell.com>
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
Jan Beulich wrote:
> Perhaps this should even be further generalized (e.g. to remove any
> "[!/]*:" pattern prefixes) to be more forward compatible?
>
Right. Need to handle the 'ioemu' subtype as well. How about just
stripping of everything before the leading '/'? E.g. like the attached
patch?
Regards,
Jim
[-- Attachment #2: blktap-script.patch --]
[-- Type: text/x-patch, Size: 530 bytes --]
diff -r c02cc832cb2d tools/hotplug/Linux/blktap
--- a/tools/hotplug/Linux/blktap Tue Apr 13 18:19:33 2010 +0100
+++ b/tools/hotplug/Linux/blktap Fri Apr 16 14:48:00 2010 -0600
@@ -59,10 +59,10 @@
if [ -n "$t" ]
then
p=$(xenstore_read "$XENBUS_PATH/params")
- # if we have a ':', chew from head including :
+ # if we have a ':', remove everything up to leading '/'
if echo $p | grep -q \:
then
- p=${p#*:}
+ p="/${p#*/}"
fi
fi
# some versions of readlink cannot be passed a regular file
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2010-04-16 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 10:13 [PATCH] tools/hotplug/Linux/blktap: remove optional tapdisk: prefix Jan Beulich
2010-04-16 20:51 ` Jim Fehlig [this message]
2010-04-19 7:38 ` Jan Beulich
[not found] ` <4BCC24A8020000780003AC70@novell.com>
2010-04-20 3:02 ` Jim Fehlig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC8CDCA.1000703@novell.com \
--to=jfehlig@novell.com \
--cc=JBeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.