All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Dave McCracken <dcm@mccr.org>
Cc: Xen Developers List <xen-devel@lists.xensource.com>
Subject: Re: Hugepages don't work on the Xen Linux git tree
Date: Tue, 20 Apr 2010 11:17:09 -0700	[thread overview]
Message-ID: <4BCDEFA5.6000509@goop.org> (raw)
In-Reply-To: <201004192127.29270.dcm@mccr.org>

On 04/19/2010 07:27 PM, Dave McCracken wrote:
> The fix I have in older kernels is for set_huge_pte_at() to call set_pmd() 
> instead.  However, in this brave new world of paravirt vectors, should I 
> instead set up a vector for it?  What is the architecturally right thing to 
> do?  However we decide to do it, expect a patch for it shortly afterward.
>   

Yeah, its a bit awkward.  A huge pte is semantically a pte, but
structurally a pmd, so which should it be?  The perhaps "cleanest" fix
might be to add a set of huge pte operators, but I don't think that's
really justified given that this is a fairly specific, narrow case.

I think on balance the best thing is to make set_huge_pte_at() call
set_pmd().

    J

      reply	other threads:[~2010-04-20 18:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20  2:27 Hugepages don't work on the Xen Linux git tree Dave McCracken
2010-04-20 18:17 ` Jeremy Fitzhardinge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCDEFA5.6000509@goop.org \
    --to=jeremy@goop.org \
    --cc=dcm@mccr.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.