From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, agraf@suse.de, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org
Subject: Re: [RFC please check] KVM: question about the commit "Use Little
Date: Wed, 21 Apr 2010 09:26:05 +0000 [thread overview]
Message-ID: <4BCEC4AD.6060305@redhat.com> (raw)
In-Reply-To: <20100421150720.16516cb7.yoshikawa.takuya@oss.ntt.co.jp>
On 04/21/2010 09:07 AM, Takuya Yoshikawa wrote:
> Hi, Alex, Avi, Marcelo
>
> I would like to ask you about the commit:
> c8240bd6f0b4b1b21ffd36dd44114d05c7afe0c0 "Use Little Endian for Dirty Bitmap"
> I pasted a snipet below!
>
> I am now confused by the Alex's comment to my recent patch:
> "change mark_page_dirty() to handle endian issues explicitly"
> in which I open-coded the generic___set_le_bit().
>
> So please explain me about the commit:
> 1. is this really the thing you intended to do?
>
I think so.
> 2. including<asm-generic/bitops/le.h> directly is OK?
> -- I made a sample patch to avoid this, see below.
>
I don't see a problem with it, it is also included from other places.
It might be possible to change it to <asm/bitops/le.h>, not sure how the
include paths are set out.
> 3. or, I misunderstand something about Alex's comment?
>
I missed the comment. What was it?
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: mtosatti@redhat.com, agraf@suse.de, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org
Subject: Re: [RFC please check] KVM: question about the commit "Use Little Endian for Dirty Bitmap"
Date: Wed, 21 Apr 2010 12:26:05 +0300 [thread overview]
Message-ID: <4BCEC4AD.6060305@redhat.com> (raw)
In-Reply-To: <20100421150720.16516cb7.yoshikawa.takuya@oss.ntt.co.jp>
On 04/21/2010 09:07 AM, Takuya Yoshikawa wrote:
> Hi, Alex, Avi, Marcelo
>
> I would like to ask you about the commit:
> c8240bd6f0b4b1b21ffd36dd44114d05c7afe0c0 "Use Little Endian for Dirty Bitmap"
> I pasted a snipet below!
>
> I am now confused by the Alex's comment to my recent patch:
> "change mark_page_dirty() to handle endian issues explicitly"
> in which I open-coded the generic___set_le_bit().
>
> So please explain me about the commit:
> 1. is this really the thing you intended to do?
>
I think so.
> 2. including<asm-generic/bitops/le.h> directly is OK?
> -- I made a sample patch to avoid this, see below.
>
I don't see a problem with it, it is also included from other places.
It might be possible to change it to <asm/bitops/le.h>, not sure how the
include paths are set out.
> 3. or, I misunderstand something about Alex's comment?
>
I missed the comment. What was it?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-04-21 9:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 6:07 [RFC please check] KVM: question about the commit Takuya Yoshikawa
2010-04-21 6:07 ` [RFC please check] KVM: question about the commit "Use Little Endian for Dirty Bitmap" Takuya Yoshikawa
[not found] ` <20100421150720.16516cb7.yoshikawa.takuya-gVGce1chcLdL9jVzuh4AOg@public.gmane.org>
2010-04-21 8:45 ` [RFC please check] KVM: question about the commit "Use Little Takuya Yoshikawa
2010-04-21 8:45 ` [RFC please check] KVM: question about the commit "Use Little Endian for Dirty Bitmap" Takuya Yoshikawa
2010-04-21 9:26 ` Avi Kivity [this message]
2010-04-21 9:26 ` Avi Kivity
[not found] ` <4BCEC4AD.6060305-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-04-21 9:32 ` Alexander Graf
2010-04-21 9:32 ` Alexander Graf
[not found] ` <F5C06DB2-AECA-4E05-8B58-74576B65D800-l3A5Bk7waGM@public.gmane.org>
2010-04-22 4:12 ` [RFC please check] KVM: question about the commit "Use Little Takuya Yoshikawa
2010-04-22 4:12 ` [RFC please check] KVM: question about the commit "Use Little Endian for Dirty Bitmap" Takuya Yoshikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCEC4AD.6060305@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.