All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fang Wenqi <anton.fang@gmail.com>
To: jgarzik@redhat.com, linux-ide@vger.kernel.org
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, antonf@turbolinux.com.cn
Subject: Re: [PATCH] drivers/ata/libata-eh.c: fix unused variable warning
Date: Thu, 22 Apr 2010 09:23:26 +0800	[thread overview]
Message-ID: <4BCFA50E.80800@gmail.com> (raw)
In-Reply-To: <4BCF1247.8080508@gmail.com>

Sorry that the title should be:
  "fix uninitialized variable warning"

not
"fix unused variable warning"


Need I re-send the patch mail ?


On 04/21/2010 10:57 PM, Fang Wenqi wrote:
>
> I'm using gcc 4.4.3 on Fedora 12:
>
> $ gcc -v
> Using built-in specs.
> Target: i686-redhat-linux
> Configured with: ../configure --prefix=/usr --mandir=/usr/share/man
> --infodir=/usr/share/info
> --with-bugurl=http://bugzilla.redhat.com/bugzilla --enable-bootstrap
> --enable-shared --enable-threads=posix --enable-checking=release
> --with-system-zlib --enable-__cxa_atexit --disable-libunwind-exceptions
> --enable-gnu-unique-object
> --enable-languages=c,c++,objc,obj-c++,java,fortran,ada
> --enable-java-awt=gtk --disable-dssi --enable-plugin
> --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre
> --enable-libgcj-multifile --enable-java-maintainer-mode
> --with-ecj-jar=/usr/share/java/eclipse-ecj.jar
> --disable-libjava-multilib --with-ppl --with-cloog --with-tune=generic
> --with-arch=i686 --build=i686-redhat-linux
> Thread model: posix
> gcc version 4.4.3 20100127 (Red Hat 4.4.3-4) (GCC)
>
>
> On 04/21/2010 10:24 PM, Alan Cox wrote:
>> On Wed, 21 Apr 2010 22:07:26 +0800
>> Fang Wenqi<anton.fang@gmail.com> wrote:
>>
>>> CC drivers/ata/libata-eh.o
>>> drivers/ata/libata-eh.c: In function ‘ata_eh_analyze_ncq_error’:
>>> drivers/ata/libata-eh.c:1642: warning: ‘tf.flags’ may be used
>>> uninitialized in this function
>>
>> Which compiler are you using. gcc 4.4.3 seems to have no trouble working
>> this out correctly and issues no warning ?
>>
>


  reply	other threads:[~2010-04-22  1:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 14:07 [PATCH] drivers/ata/libata-eh.c: fix unused variable warning Fang Wenqi
2010-04-21 14:24 ` Alan Cox
2010-04-21 14:57   ` Fang Wenqi
2010-04-22  1:23     ` Fang Wenqi [this message]
2010-04-23  6:30       ` Tejun Heo
2010-04-23  6:43         ` Jeff Garzik
2010-04-23  7:01           ` Tejun Heo
2010-04-23 13:52             ` Jeff Garzik
2010-04-23 14:02               ` Tejun Heo
2010-04-23 14:07               ` Sergei Shtylyov
2010-04-23 14:18                 ` Jeff Garzik
2010-04-23  6:48         ` Fang Wenqi
2010-04-23  1:54 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCFA50E.80800@gmail.com \
    --to=anton.fang@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=antonf@turbolinux.com.cn \
    --cc=jgarzik@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.