From: Jeff Garzik <jeff@garzik.org>
To: Fang Wenqi <anton.fang@gmail.com>
Cc: jgarzik@redhat.com, linux-ide@vger.kernel.org, antonf@turbolinux.com.cn
Subject: Re: [PATCH] drivers/ata/libata-eh.c: fix unused variable warning
Date: Thu, 22 Apr 2010 21:54:55 -0400 [thread overview]
Message-ID: <4BD0FDEF.1070504@garzik.org> (raw)
In-Reply-To: <1271858846-1706-1-git-send-email-antonf@turbolinux.com.cn>
On 04/21/2010 10:07 AM, Fang Wenqi wrote:
> CC drivers/ata/libata-eh.o
> drivers/ata/libata-eh.c: In function ‘ata_eh_analyze_ncq_error’:
> drivers/ata/libata-eh.c:1642: warning: ‘tf.flags’ may be used uninitialized in this function
>
> Signed-off-by: Fang Wenqi<antonf@turbolinux.com.cn>
> ---
> drivers/ata/libata-eh.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index 9f6cfac..125ec25 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -1601,7 +1601,7 @@ void ata_eh_analyze_ncq_error(struct ata_link *link)
> struct ata_eh_context *ehc =&link->eh_context;
> struct ata_device *dev = link->device;
> struct ata_queued_cmd *qc;
> - struct ata_taskfile tf;
> + struct ata_taskfile uninitialized_var(tf);
> int tag, rc;
NAK - the warning reflects an actual bug.
prev parent reply other threads:[~2010-04-23 1:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 14:07 [PATCH] drivers/ata/libata-eh.c: fix unused variable warning Fang Wenqi
2010-04-21 14:24 ` Alan Cox
2010-04-21 14:57 ` Fang Wenqi
2010-04-22 1:23 ` Fang Wenqi
2010-04-23 6:30 ` Tejun Heo
2010-04-23 6:43 ` Jeff Garzik
2010-04-23 7:01 ` Tejun Heo
2010-04-23 13:52 ` Jeff Garzik
2010-04-23 14:02 ` Tejun Heo
2010-04-23 14:07 ` Sergei Shtylyov
2010-04-23 14:18 ` Jeff Garzik
2010-04-23 6:48 ` Fang Wenqi
2010-04-23 1:54 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD0FDEF.1070504@garzik.org \
--to=jeff@garzik.org \
--cc=anton.fang@gmail.com \
--cc=antonf@turbolinux.com.cn \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.