From: Patrick McHardy <kaber@trash.net>
To: Dan Carpenter <error27@gmail.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
"Eric W. Biederman" <ebiederm@aristanetworks.com>,
Mitch Williams <mitch.a.williams@intel.com>,
"David S. Miller" <davem@davemloft.net>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] rtnetlink: potential ERR_PTR dereference
Date: Thu, 22 Apr 2010 10:35:06 +0000 [thread overview]
Message-ID: <4BD0265A.2000301@trash.net> (raw)
In-Reply-To: <20100422095327.GP29647@bicker>
Dan Carpenter wrote:
> In the original code, if rtnl_create_link() returned an ERR_PTR then that
> would get passed to rtnl_configure_link() which dereferences it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> Found by a static checker, and compile tested only. :/
Looks fine to me.
Acked-by: Patrick McHardy <kaber@trash.net>
WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: Dan Carpenter <error27@gmail.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
"Eric W. Biederman" <ebiederm@aristanetworks.com>,
Mitch Williams <mitch.a.williams@intel.com>,
"David S. Miller" <davem@davemloft.net>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] rtnetlink: potential ERR_PTR dereference
Date: Thu, 22 Apr 2010 12:35:06 +0200 [thread overview]
Message-ID: <4BD0265A.2000301@trash.net> (raw)
In-Reply-To: <20100422095327.GP29647@bicker>
Dan Carpenter wrote:
> In the original code, if rtnl_create_link() returned an ERR_PTR then that
> would get passed to rtnl_configure_link() which dereferences it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> Found by a static checker, and compile tested only. :/
Looks fine to me.
Acked-by: Patrick McHardy <kaber@trash.net>
next prev parent reply other threads:[~2010-04-22 10:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 9:53 [patch] rtnetlink: potential ERR_PTR dereference Dan Carpenter
2010-04-22 9:53 ` Dan Carpenter
2010-04-22 10:35 ` Patrick McHardy [this message]
2010-04-22 10:35 ` Patrick McHardy
2010-04-22 22:57 ` David Miller
2010-04-22 22:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD0265A.2000301@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=ebiederm@aristanetworks.com \
--cc=eric.dumazet@gmail.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.