* [PATCH] libata: use __ratelimit
@ 2010-04-12 12:11 Akinobu Mita
2010-04-23 2:07 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2010-04-12 12:11 UTC (permalink / raw)
To: linux-ide; +Cc: Akinobu Mita, Jeff Garzik
Use __ratelimit() instead of its own private rate limit implementation.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org
---
drivers/ata/libata-core.c | 19 +++----------------
1 files changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 49cffb6..1e0ce69 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -65,6 +65,7 @@
#include <linux/libata.h>
#include <asm/byteorder.h>
#include <linux/cdrom.h>
+#include <linux/ratelimit.h>
#include "libata.h"
@@ -6700,25 +6701,11 @@ static void __exit ata_exit(void)
subsys_initcall(ata_init);
module_exit(ata_exit);
-static unsigned long ratelimit_time;
-static DEFINE_SPINLOCK(ata_ratelimit_lock);
+static DEFINE_RATELIMIT_STATE(ratelimit, HZ / 5, 1);
int ata_ratelimit(void)
{
- int rc;
- unsigned long flags;
-
- spin_lock_irqsave(&ata_ratelimit_lock, flags);
-
- if (time_after(jiffies, ratelimit_time)) {
- rc = 1;
- ratelimit_time = jiffies + (HZ/5);
- } else
- rc = 0;
-
- spin_unlock_irqrestore(&ata_ratelimit_lock, flags);
-
- return rc;
+ return __ratelimit(&ratelimit);
}
/**
--
1.6.0.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: use __ratelimit
2010-04-12 12:11 [PATCH] libata: use __ratelimit Akinobu Mita
@ 2010-04-23 2:07 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2010-04-23 2:07 UTC (permalink / raw)
To: Akinobu Mita; +Cc: linux-ide
On 04/12/2010 08:11 AM, Akinobu Mita wrote:
> Use __ratelimit() instead of its own private rate limit implementation.
>
> Signed-off-by: Akinobu Mita<akinobu.mita@gmail.com>
> Cc: Jeff Garzik<jgarzik@pobox.com>
> Cc: linux-ide@vger.kernel.org
> ---
> drivers/ata/libata-core.c | 19 +++----------------
> 1 files changed, 3 insertions(+), 16 deletions(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-23 2:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-12 12:11 [PATCH] libata: use __ratelimit Akinobu Mita
2010-04-23 2:07 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.