From: Li Zefan <lizf@cn.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [BUGFIX][PATCH] memcg rcu lock fix v3
Date: Fri, 23 Apr 2010 14:10:32 +0800 [thread overview]
Message-ID: <4BD139D8.80309@cn.fujitsu.com> (raw)
In-Reply-To: <20100423130349.f320d0be.kamezawa.hiroyu@jp.fujitsu.com>
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> css_id() should be called under rcu_read_lock().
> Following is a report from Li Zefan.
> ==
> ===================================================
> [ INFO: suspicious rcu_dereference_check() usage. ]
> ---------------------------------------------------
> kernel/cgroup.c:4438 invoked rcu_dereference_check() without protection!
>
> other info that might help us debug this:
>
>
> rcu_scheduler_active = 1, debug_locks = 1
> 1 lock held by kswapd0/31:
> #0: (swap_lock){+.+.-.}, at: [<c05058bb>] swap_info_get+0x4b/0xd0
>
> stack backtrace:
...
>
> And css_is_ancestor() should be called under rcu_read_lock().
>
>
> Reported-by: Li Zefan <lizf@cn.fujitsu.com>
> Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
> Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
With this patch applied, I did some more test, and no warning was triggered.
Tested-by: Li Zefan <lizf@cn.fujitsu.com>
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [BUGFIX][PATCH] memcg rcu lock fix v3
Date: Fri, 23 Apr 2010 14:10:32 +0800 [thread overview]
Message-ID: <4BD139D8.80309@cn.fujitsu.com> (raw)
In-Reply-To: <20100423130349.f320d0be.kamezawa.hiroyu@jp.fujitsu.com>
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> css_id() should be called under rcu_read_lock().
> Following is a report from Li Zefan.
> ==
> ===================================================
> [ INFO: suspicious rcu_dereference_check() usage. ]
> ---------------------------------------------------
> kernel/cgroup.c:4438 invoked rcu_dereference_check() without protection!
>
> other info that might help us debug this:
>
>
> rcu_scheduler_active = 1, debug_locks = 1
> 1 lock held by kswapd0/31:
> #0: (swap_lock){+.+.-.}, at: [<c05058bb>] swap_info_get+0x4b/0xd0
>
> stack backtrace:
...
>
> And css_is_ancestor() should be called under rcu_read_lock().
>
>
> Reported-by: Li Zefan <lizf@cn.fujitsu.com>
> Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
> Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
With this patch applied, I did some more test, and no warning was triggered.
Tested-by: Li Zefan <lizf@cn.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-23 6:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 3:00 [BUG] an RCU warning in memcg Li Zefan
2010-04-23 3:00 ` Li Zefan
2010-04-23 3:14 ` [BUGFIX][PATCH] memcg rcu lock fix in swap code (Was " KAMEZAWA Hiroyuki
2010-04-23 3:14 ` KAMEZAWA Hiroyuki
2010-04-23 3:32 ` Balbir Singh
2010-04-23 3:32 ` Balbir Singh
2010-04-23 3:49 ` Li Zefan
2010-04-23 3:49 ` Li Zefan
2010-04-23 3:55 ` Li Zefan
2010-04-23 3:55 ` Li Zefan
2010-04-23 3:50 ` KAMEZAWA Hiroyuki
2010-04-23 3:50 ` KAMEZAWA Hiroyuki
2010-04-23 4:02 ` Li Zefan
2010-04-23 4:02 ` Li Zefan
2010-04-23 3:58 ` [BUGFIX][PATCH] memcg rcu lock fix v2 KAMEZAWA Hiroyuki
2010-04-23 3:58 ` KAMEZAWA Hiroyuki
2010-04-23 4:03 ` [BUGFIX][PATCH] memcg rcu lock fix v3 KAMEZAWA Hiroyuki
2010-04-23 4:03 ` KAMEZAWA Hiroyuki
2010-04-23 4:41 ` Daisuke Nishimura
2010-04-23 4:41 ` Daisuke Nishimura
2010-04-23 6:10 ` Li Zefan [this message]
2010-04-23 6:10 ` Li Zefan
2010-04-23 6:05 ` KAMEZAWA Hiroyuki
2010-04-23 6:05 ` KAMEZAWA Hiroyuki
2010-04-23 7:00 ` Balbir Singh
2010-04-23 7:00 ` Balbir Singh
2010-04-23 6:57 ` KAMEZAWA Hiroyuki
2010-04-23 6:57 ` KAMEZAWA Hiroyuki
2010-04-23 19:34 ` Paul E. McKenney
2010-04-23 19:34 ` Paul E. McKenney
2010-04-24 2:08 ` KAMEZAWA Hiroyuki
2010-04-24 2:08 ` KAMEZAWA Hiroyuki
2010-04-24 4:27 ` Paul E. McKenney
2010-04-24 4:27 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD139D8.80309@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.