From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] misc: add gpio based status led driver
Date: Sun, 25 Apr 2010 06:59:21 +0800 [thread overview]
Message-ID: <4BD377C9.6010809@wytron.com.tw> (raw)
In-Reply-To: <20100424223245.29B4BEDD5FB@gemini.denx.de>
On 04/25/2010 06:32 AM, Wolfgang Denk wrote:
>
> I mean, which board in U-Boot uses this code? I didn't find any.
>
> The convention is not to add unused code. If there are no real users
> for this, the patch should be delayed until a board gets added that
> actually uses it.
>
>
Hi Wolfgang,
These nios2 boards are now supported with the nios2-generic board
approach, like that of microblaze-generic, instead of adding every nios2
board to u-boot mainline. The nios2-generic board patch was applied to
Scott's next branch.
The gpio led can be enabled with the following added to the board config
file.
/*
* STATUS LED
*/
#define CONFIG_STATUS_LED /* Enable status driver */
#define CONFIG_GPIO_LED /* Enable gpio led driver */
#define STATUS_LED_BIT 2 /* Bit-2 on GPIO */
#define STATUS_LED_STATE 1 /* Blinking */
#define STATUS_LED_PERIOD (500 / CONFIG_SYS_NIOS_TMRMS) /* 500 msec */
Cheers,
Thomas
next prev parent reply other threads:[~2010-04-24 22:59 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-27 4:54 [U-Boot] [PATCH] nios2: add gpio based status led driver Thomas Chou
2010-04-20 13:19 ` Scott McNutt
2010-04-20 15:05 ` Thomas Chou
2010-04-20 16:19 ` Scott McNutt
2010-04-21 0:33 ` Thomas Chou
2010-04-21 0:45 ` [U-Boot] [PATCH v2] misc: " Thomas Chou
2010-04-24 19:23 ` Wolfgang Denk
2010-04-24 22:07 ` Thomas Chou
2010-04-24 22:32 ` Wolfgang Denk
2010-04-24 22:59 ` Thomas Chou [this message]
2010-04-25 0:48 ` Scott McNutt
2010-04-25 18:15 ` Wolfgang Denk
2010-04-25 18:14 ` Wolfgang Denk
2010-04-28 3:51 ` Thomas Chou
2010-05-04 22:30 ` Wolfgang Denk
2010-05-04 22:53 ` Scott McNutt
2010-05-05 0:09 ` Thomas Chou
2010-04-30 3:34 ` [U-Boot] [PATCH 0/6] add gpio_led and altera_spi drivers Thomas Chou
2010-04-30 3:34 ` [U-Boot] [PATCH 1/6 v4] nios2: add gpio support Thomas Chou
2010-05-21 14:39 ` [U-Boot] [Nios2-dev] " Ian Abbott
2010-05-25 19:39 ` [U-Boot] " Scott McNutt
2010-04-30 3:34 ` [U-Boot] [PATCH 2/6 v2] misc: add gpio based status led driver Thomas Chou
2010-05-21 14:40 ` [U-Boot] [Nios2-dev] " Ian Abbott
2010-05-25 19:39 ` [U-Boot] " Scott McNutt
2010-04-30 3:34 ` [U-Boot] [PATCH 3/6 v3] nios2: add gpio support to nios2-generic board Thomas Chou
2010-04-30 14:24 ` Scott McNutt
2010-04-30 15:21 ` Thomas Chou
2010-04-30 15:35 ` Scott McNutt
2010-05-21 14:41 ` [U-Boot] [Nios2-dev] " Ian Abbott
2010-05-25 19:40 ` [U-Boot] " Scott McNutt
2010-04-30 3:34 ` [U-Boot] [PATCH 4/6 v10] spi: add altera spi controller support Thomas Chou
2010-05-21 14:43 ` [U-Boot] [Nios2-dev] " Ian Abbott
2010-05-25 19:40 ` [U-Boot] " Scott McNutt
2010-04-30 3:34 ` [U-Boot] [PATCH 5/6 v2] spi_flash: support old STMicro parts with RES Thomas Chou
2010-04-30 12:48 ` Mike Frysinger
2010-04-30 13:15 ` Thomas Chou
2010-04-30 13:11 ` [U-Boot] [PATCH 5/6 v3] " Thomas Chou
2010-04-30 13:25 ` Mike Frysinger
2010-05-05 7:21 ` Mike Frysinger
2010-05-05 7:34 ` Thomas Chou
2010-05-05 19:57 ` Wolfgang Denk
2010-05-05 21:40 ` Mike Frysinger
2010-05-06 0:20 ` Thomas Chou
2010-04-30 3:34 ` [U-Boot] [PATCH 6/6 v3] nios2: add spi flash support to nios2-generic board Thomas Chou
2010-05-21 14:44 ` [U-Boot] [Nios2-dev] " Ian Abbott
2010-05-25 19:52 ` [U-Boot] " Scott McNutt
2010-04-27 3:29 ` [U-Boot] [PATCH] nios2: add epcs, gpio led and mmc_spi to nios2-generic Thomas Chou
2010-04-28 3:08 ` [U-Boot] [PATCH v2] " Thomas Chou
2010-06-09 4:27 ` [U-Boot] [PATCH v2] misc: add gpio based status led driver Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD377C9.6010809@wytron.com.tw \
--to=thomas@wytron.com.tw \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.