All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki Poulose <suzuki@in.ibm.com>
To: risrajak@in.ibm.com, ltp-list@lists.sourceforge.net
Subject: [LTP] PATCH : test_fs_bind testscript for busybox machines
Date: Mon, 26 Apr 2010 12:06:51 +0530	[thread overview]
Message-ID: <4BD53483.9080603@in.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Hi,

The test_fs_bind testscript hangs indefinitely when run on a machine 
where busybox applets are used.

The test hangs while trying to restore the mounts after a test run.


This happens because the "xargs" applet from busybox doesn't understand 
the --max-args=1 option. Thus, the mounts from the test are not removed 
and this goes on in a loop, indefinitely.

This could be avoided by using "-n" option which is supported by both 
the implementations of xargs.


Attached the patch here.

Thanks

Suzuki

[-- Attachment #2: fix_fs_bind_tests_for_busybox_machines.diff --]
[-- Type: text/plain, Size: 632 bytes --]


Signed-off-by: Suzuki K P <suzuki@in.ibm.com>

Index: ltp/testscripts/test_fs_bind.sh
===================================================================
--- ltp.orig/testscripts/test_fs_bind.sh	2009-12-22 03:28:25.000000000 +0000
+++ ltp/testscripts/test_fs_bind.sh	2010-04-26 05:50:41.000000000 +0000
@@ -238,7 +238,7 @@
 	# new mounts around and will never remove mounts outside the test
 	# directory
 	( while grep_proc_mounts ; do
-		grep_proc_mounts | awk '{print $2}' | xargs -r --max-args=1 umount -l
+		grep_proc_mounts | awk '{print $2}' | xargs -r -n 1 umount -l
 	done ) >& /dev/null
 	
 	# mount list and exit with 0

[-- Attachment #3: Type: text/plain, Size: 79 bytes --]

------------------------------------------------------------------------------

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

             reply	other threads:[~2010-04-26  6:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-26  6:36 Suzuki Poulose [this message]
2010-04-26  7:48 ` [LTP] PATCH : test_fs_bind testscript for busybox machines Rishikesh K Rajak
2010-05-04 22:35 ` Matt Helsley
2010-05-05  4:44   ` Rishikesh K Rajak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD53483.9080603@in.ibm.com \
    --to=suzuki@in.ibm.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=risrajak@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.