* [LTP] PATCH : test_fs_bind testscript for busybox machines
@ 2010-04-26 6:36 Suzuki Poulose
2010-04-26 7:48 ` Rishikesh K Rajak
2010-05-04 22:35 ` Matt Helsley
0 siblings, 2 replies; 4+ messages in thread
From: Suzuki Poulose @ 2010-04-26 6:36 UTC (permalink / raw)
To: risrajak, ltp-list
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
Hi,
The test_fs_bind testscript hangs indefinitely when run on a machine
where busybox applets are used.
The test hangs while trying to restore the mounts after a test run.
This happens because the "xargs" applet from busybox doesn't understand
the --max-args=1 option. Thus, the mounts from the test are not removed
and this goes on in a loop, indefinitely.
This could be avoided by using "-n" option which is supported by both
the implementations of xargs.
Attached the patch here.
Thanks
Suzuki
[-- Attachment #2: fix_fs_bind_tests_for_busybox_machines.diff --]
[-- Type: text/plain, Size: 632 bytes --]
Signed-off-by: Suzuki K P <suzuki@in.ibm.com>
Index: ltp/testscripts/test_fs_bind.sh
===================================================================
--- ltp.orig/testscripts/test_fs_bind.sh 2009-12-22 03:28:25.000000000 +0000
+++ ltp/testscripts/test_fs_bind.sh 2010-04-26 05:50:41.000000000 +0000
@@ -238,7 +238,7 @@
# new mounts around and will never remove mounts outside the test
# directory
( while grep_proc_mounts ; do
- grep_proc_mounts | awk '{print $2}' | xargs -r --max-args=1 umount -l
+ grep_proc_mounts | awk '{print $2}' | xargs -r -n 1 umount -l
done ) >& /dev/null
# mount list and exit with 0
[-- Attachment #3: Type: text/plain, Size: 79 bytes --]
------------------------------------------------------------------------------
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] PATCH : test_fs_bind testscript for busybox machines
2010-04-26 6:36 [LTP] PATCH : test_fs_bind testscript for busybox machines Suzuki Poulose
@ 2010-04-26 7:48 ` Rishikesh K Rajak
2010-05-04 22:35 ` Matt Helsley
1 sibling, 0 replies; 4+ messages in thread
From: Rishikesh K Rajak @ 2010-04-26 7:48 UTC (permalink / raw)
To: suzuki; +Cc: ltp-list
[-- Attachment #1: Type: text/plain, Size: 2087 bytes --]
Looks fine.
Acked-By: Rishikesh K Rajak <risrajak@linux.vnet.ibm.com>
committed as d9f3d25b9db35073c7104b759d526869d9867692
Thanks
-Rishi
suzuki@linux.vnet
.ibm.com
To
04/26/2010 12:06 Rishikesh K Rajak/India/IBM@IBMIN,
PM ltp-list@lists.sourceforge.net
cc
Robert Paulsen
<rpaulsen@us.ibm.com>
Subject
PATCH : test_fs_bind testscript for
busybox machines
Hi,
The test_fs_bind testscript hangs indefinitely when run on a machine
where busybox applets are used.
The test hangs while trying to restore the mounts after a test run.
This happens because the "xargs" applet from busybox doesn't understand
the --max-args=1 option. Thus, the mounts from the test are not removed
and this goes on in a loop, indefinitely.
This could be avoided by using "-n" option which is supported by both
the implementations of xargs.
Attached the patch here.
Thanks
Suzuki
(See attached file: fix_fs_bind_tests_for_busybox_machines.diff)
[-- Attachment #2: fix_fs_bind_tests_for_busybox_machines.diff --]
[-- Type: application/octet-stream, Size: 648 bytes --]
Signed-off-by: Suzuki K P <suzuki@in.ibm.com>
Index: ltp/testscripts/test_fs_bind.sh
===================================================================
--- ltp.orig/testscripts/test_fs_bind.sh 2009-12-22 03:28:25.000000000 +0000
+++ ltp/testscripts/test_fs_bind.sh 2010-04-26 05:50:41.000000000 +0000
@@ -238,7 +238,7 @@
# new mounts around and will never remove mounts outside the test
# directory
( while grep_proc_mounts ; do
- grep_proc_mounts | awk '{print $2}' | xargs -r --max-args=1 umount -l
+ grep_proc_mounts | awk '{print $2}' | xargs -r -n 1 umount -l
done ) >& /dev/null
# mount list and exit with 0
[-- Attachment #3: Type: text/plain, Size: 79 bytes --]
------------------------------------------------------------------------------
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] PATCH : test_fs_bind testscript for busybox machines
2010-04-26 6:36 [LTP] PATCH : test_fs_bind testscript for busybox machines Suzuki Poulose
2010-04-26 7:48 ` Rishikesh K Rajak
@ 2010-05-04 22:35 ` Matt Helsley
2010-05-05 4:44 ` Rishikesh K Rajak
1 sibling, 1 reply; 4+ messages in thread
From: Matt Helsley @ 2010-05-04 22:35 UTC (permalink / raw)
To: Suzuki Poulose; +Cc: risrajak, ltp-list
On Mon, Apr 26, 2010 at 12:06:51PM +0530, Suzuki Poulose wrote:
> Hi,
>
> The test_fs_bind testscript hangs indefinitely when run on a machine
> where busybox applets are used.
>
> The test hangs while trying to restore the mounts after a test run.
>
>
> This happens because the "xargs" applet from busybox doesn't
> understand the --max-args=1 option. Thus, the mounts from the test
> are not removed and this goes on in a loop, indefinitely.
>
> This could be avoided by using "-n" option which is supported by
> both the implementations of xargs.
>
>
> Attached the patch here.
>
> Thanks
>
> Suzuki
Just noticed this thread. Looks good, thanks!
Acked-by: Matt Helsley <matthltc@us.ibm.com>
>
> Signed-off-by: Suzuki K P <suzuki@in.ibm.com>
>
> Index: ltp/testscripts/test_fs_bind.sh
> ===================================================================
> --- ltp.orig/testscripts/test_fs_bind.sh 2009-12-22 03:28:25.000000000 +0000
> +++ ltp/testscripts/test_fs_bind.sh 2010-04-26 05:50:41.000000000 +0000
> @@ -238,7 +238,7 @@
> # new mounts around and will never remove mounts outside the test
> # directory
> ( while grep_proc_mounts ; do
> - grep_proc_mounts | awk '{print $2}' | xargs -r --max-args=1 umount -l
> + grep_proc_mounts | awk '{print $2}' | xargs -r -n 1 umount -l
> done ) >& /dev/null
>
> # mount list and exit with 0
> ------------------------------------------------------------------------------
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] PATCH : test_fs_bind testscript for busybox machines
2010-05-04 22:35 ` Matt Helsley
@ 2010-05-05 4:44 ` Rishikesh K Rajak
0 siblings, 0 replies; 4+ messages in thread
From: Rishikesh K Rajak @ 2010-05-05 4:44 UTC (permalink / raw)
To: Matt Helsley; +Cc: ltp-list, suzuki
Thanks matt. This has been already applied and released to April month LTP
tarball.
Commit ID : d9f3d25b9db35073c7104b759d526869d9867692
Warm Regards
Rishi
Linux Tech Centre
IBM-ISTL, Manyata
Bangalore
Matt Helsley
<matthltc@us.ibm.
com> To
suzuki@linux.vnet.ibm.com
05/05/2010 04:05 cc
AM Rishikesh K Rajak/India/IBM@IBMIN,
ltp-list@lists.sourceforge.net
Subject
Re: [LTP] PATCH : test_fs_bind
testscript for busybox machines
On Mon, Apr 26, 2010 at 12:06:51PM +0530, Suzuki Poulose wrote:
> Hi,
>
> The test_fs_bind testscript hangs indefinitely when run on a machine
> where busybox applets are used.
>
> The test hangs while trying to restore the mounts after a test run.
>
>
> This happens because the "xargs" applet from busybox doesn't
> understand the --max-args=1 option. Thus, the mounts from the test
> are not removed and this goes on in a loop, indefinitely.
>
> This could be avoided by using "-n" option which is supported by
> both the implementations of xargs.
>
>
> Attached the patch here.
>
> Thanks
>
> Suzuki
Just noticed this thread. Looks good, thanks!
Acked-by: Matt Helsley <matthltc@us.ibm.com>
>
> Signed-off-by: Suzuki K P <suzuki@in.ibm.com>
>
> Index: ltp/testscripts/test_fs_bind.sh
> ===================================================================
> --- ltp.orig/testscripts/test_fs_bind.sh 2009-12-22
03:28:25.000000000 +0000
> +++ ltp/testscripts/test_fs_bind.sh 2010-04-26
05:50:41.000000000 +0000
> @@ -238,7 +238,7 @@
> # new mounts around and will never remove mounts outside the
test
> # directory
> ( while grep_proc_mounts ; do
> - grep_proc_mounts | awk '{print $2}' | xargs -r
--max-args=1 umount -l
> + grep_proc_mounts | awk '{print $2}' | xargs -r -n
1 umount -l
> done ) >& /dev/null
>
> # mount list and exit with 0
>
------------------------------------------------------------------------------
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-05-05 4:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-26 6:36 [LTP] PATCH : test_fs_bind testscript for busybox machines Suzuki Poulose
2010-04-26 7:48 ` Rishikesh K Rajak
2010-05-04 22:35 ` Matt Helsley
2010-05-05 4:44 ` Rishikesh K Rajak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.