[Qemu-devel] Re: [PATCH] A bit optimization for tlb_set_page()

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

Jun Koi wrote:
> It is not necessary to continue searching for watchpoint when we
> already found one and setup for handling watchpoint in a search loop
> in tlb_set_page().
> This patch breaks that search loop on then.

Acked-by: Jan Kiszka <jan.kiszka@siemens.com>

> 
> Signed-off-by: Jun Koi <junkoi2004@gmail.com>
> 
> diff --git a/exec.c b/exec.c
> index 14d1fd7..6329775 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2240,6 +2240,7 @@ void tlb_set_page(CPUState *env, target_ulong vaddr,
>              /* TODO: The memory case can be optimized by not trapping
>                 reads of pages with a write breakpoint.  */

PS: Don't you also want to address this todo while you are at it? :)

>              address |= TLB_MMIO;
> +            break;
>          }
>      }
> 
> 
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]