From: Tejun Heo <tj@kernel.org>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH 6/8] PM: Add suspend blocking work.
Date: Wed, 28 Apr 2010 09:18:28 +0200 [thread overview]
Message-ID: <4BD7E144.6050608@kernel.org> (raw)
In-Reply-To: <i2vd6200be21004280002tde778c02h1586b4c06de2a89a@mail.gmail.com>
Hello,
On 04/28/2010 09:02 AM, Arve Hjønnevåg wrote:
>> Maybe work->active can be an atomic_t and the lock can be removed?
>
> I need the spinlock to prevent the work from getting re-queued before
> suspend_unblock.
OIC.
> I'm not sure what the best terminology is here, but cancel_work_sync()
> only waits for work running on all the cpu-workqueues of the last
> workqueue. So, if the caller queued the work on more than one
> workqueue, suspend_blocking_work_destroy does not ensure that the
> suspend_blocking_work structure is not still in use (it should trigger
> the WARN_ON though).
Right, I was thinking about different cpu_workqueues and yeah, the
terminology gets pretty confusing.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
Alan Stern <stern@rowland.harvard.edu>,
Oleg Nesterov <oleg@redhat.com>, Pavel Machek <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 6/8] PM: Add suspend blocking work.
Date: Wed, 28 Apr 2010 09:18:28 +0200 [thread overview]
Message-ID: <4BD7E144.6050608@kernel.org> (raw)
In-Reply-To: <i2vd6200be21004280002tde778c02h1586b4c06de2a89a@mail.gmail.com>
Hello,
On 04/28/2010 09:02 AM, Arve Hjønnevåg wrote:
>> Maybe work->active can be an atomic_t and the lock can be removed?
>
> I need the spinlock to prevent the work from getting re-queued before
> suspend_unblock.
OIC.
> I'm not sure what the best terminology is here, but cancel_work_sync()
> only waits for work running on all the cpu-workqueues of the last
> workqueue. So, if the caller queued the work on more than one
> workqueue, suspend_blocking_work_destroy does not ensure that the
> suspend_blocking_work structure is not still in use (it should trigger
> the WARN_ON though).
Right, I was thinking about different cpu_workqueues and yeah, the
terminology gets pretty confusing.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2010-04-28 7:18 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 4:31 [PATCH 0/9] Suspend block api (version 5) Arve Hjønnevåg
2010-04-28 4:31 ` [PATCH 1/8] PM: Add suspend block api Arve Hjønnevåg
2010-04-28 4:31 ` [PATCH 2/8] PM: suspend_block: Add driver to access suspend blockers from user-space Arve Hjønnevåg
2010-04-28 4:31 ` Arve Hjønnevåg
2010-04-28 4:31 ` [PATCH 3/8] PM: suspend_block: Abort task freezing if a suspend_blocker is active Arve Hjønnevåg
2010-04-28 4:31 ` Arve Hjønnevåg
2010-04-28 4:31 ` [PATCH 4/8] PM: suspend_block: Add debugfs file Arve Hjønnevåg
2010-04-28 4:31 ` Arve Hjønnevåg
2010-04-28 4:31 ` [PATCH 5/8] PM: suspend_block: Add suspend_blocker stats Arve Hjønnevåg
2010-04-28 4:31 ` Arve Hjønnevåg
2010-04-28 4:31 ` [PATCH 6/8] PM: Add suspend blocking work Arve Hjønnevåg
2010-04-28 4:31 ` Arve Hjønnevåg
2010-04-28 4:31 ` [PATCH 7/8] Input: Block suspend while event queue is not empty Arve Hjønnevåg
2010-04-28 4:31 ` Arve Hjønnevåg
2010-04-28 4:31 ` [PATCH 8/8] power_supply: Block suspend while power supply change notifications are pending Arve Hjønnevåg
2010-04-28 4:31 ` Arve Hjønnevåg
2010-04-28 6:06 ` [PATCH 6/8] PM: Add suspend blocking work Pavel Machek
2010-04-28 6:06 ` Pavel Machek
2010-04-28 6:44 ` Tejun Heo
2010-04-28 6:44 ` Tejun Heo
2010-04-28 7:02 ` Arve Hjønnevåg
2010-04-28 7:18 ` Tejun Heo [this message]
2010-04-28 7:18 ` Tejun Heo
2010-04-28 7:02 ` Arve Hjønnevåg
2010-04-28 19:40 ` Oleg Nesterov
2010-04-28 20:22 ` Tejun Heo
2010-04-28 20:22 ` Tejun Heo
2010-04-28 21:08 ` Rafael J. Wysocki
2010-04-28 21:08 ` Rafael J. Wysocki
2010-04-29 18:58 ` Oleg Nesterov
2010-04-29 18:58 ` Oleg Nesterov
2010-04-29 19:44 ` [PATCH 0/2] workqueue fixlets (Was: PM: Add suspend blocking work.) Oleg Nesterov
2010-04-29 19:44 ` Oleg Nesterov
2010-04-29 19:45 ` [PATCH 1/2] workqueues: flush_delayed_work: keep the original workqueue for re-queueing Oleg Nesterov
2010-04-29 19:45 ` Oleg Nesterov
2010-04-30 5:15 ` Tejun Heo
2010-04-30 5:15 ` Tejun Heo
2010-04-29 19:45 ` [PATCH 2/2] workqueues: export keventd_wq Oleg Nesterov
2010-04-29 19:45 ` Oleg Nesterov
2010-04-30 5:16 ` Tejun Heo
2010-04-30 5:16 ` Tejun Heo
2010-04-30 5:39 ` Arve Hjønnevåg
2010-04-30 5:39 ` Arve Hjønnevåg
2010-04-30 5:52 ` Tejun Heo
2010-04-30 5:52 ` Tejun Heo
2010-04-30 18:05 ` Oleg Nesterov
2010-04-30 18:05 ` Oleg Nesterov
2010-04-30 18:11 ` Tejun Heo
2010-04-30 18:11 ` Tejun Heo
2010-04-29 21:08 ` [PATCH 6/8] PM: Add suspend blocking work Rafael J. Wysocki
2010-04-29 21:08 ` Rafael J. Wysocki
2010-04-28 21:09 ` Rafael J. Wysocki
2010-04-28 21:09 ` Rafael J. Wysocki
2010-04-28 22:09 ` Arve Hjønnevåg
2010-04-28 22:09 ` Arve Hjønnevåg
2010-04-28 22:19 ` Rafael J. Wysocki
2010-04-28 22:19 ` Rafael J. Wysocki
2010-04-29 3:47 ` Arve Hjønnevåg
2010-04-29 21:09 ` Rafael J. Wysocki
2010-04-29 21:09 ` Rafael J. Wysocki
2010-04-29 3:47 ` Arve Hjønnevåg
2010-04-28 19:40 ` Oleg Nesterov
2010-04-28 5:07 ` [PATCH 3/8] PM: suspend_block: Abort task freezing if a suspend_blocker is active Pavel Machek
2010-04-28 5:07 ` Pavel Machek
2010-04-28 20:58 ` [PATCH 2/8] PM: suspend_block: Add driver to access suspend blockers from user-space Rafael J. Wysocki
2010-04-28 22:31 ` Arve Hjønnevåg
2010-04-28 23:05 ` Rafael J. Wysocki
2010-04-28 23:38 ` Arve Hjønnevåg
2010-04-28 23:38 ` Arve Hjønnevåg
2010-04-29 21:11 ` Rafael J. Wysocki
2010-04-29 21:11 ` Rafael J. Wysocki
2010-04-29 23:41 ` Arve Hjønnevåg
2010-04-29 23:41 ` Arve Hjønnevåg
2010-04-28 23:05 ` Rafael J. Wysocki
2010-04-28 22:31 ` Arve Hjønnevåg
2010-04-28 20:58 ` Rafael J. Wysocki
2010-04-28 6:07 ` [PATCH 1/8] PM: Add suspend block api Pavel Machek
2010-04-28 6:07 ` Pavel Machek
2010-04-28 19:13 ` Alan Stern
2010-04-28 21:13 ` Rafael J. Wysocki
2010-04-28 21:13 ` Rafael J. Wysocki
2010-04-28 23:35 ` Arve Hjønnevåg
2010-04-29 15:41 ` Alan Stern
2010-04-29 15:41 ` Alan Stern
2010-04-29 23:39 ` Arve Hjønnevåg
2010-04-29 23:39 ` Arve Hjønnevåg
2010-04-30 14:41 ` Alan Stern
2010-04-30 14:41 ` Alan Stern
2010-04-28 23:35 ` Arve Hjønnevåg
2010-04-28 19:13 ` Alan Stern
2010-04-28 20:50 ` Rafael J. Wysocki
2010-04-28 20:50 ` Rafael J. Wysocki
2010-04-29 3:37 ` Arve Hjønnevåg
2010-04-29 3:37 ` Arve Hjønnevåg
2010-04-29 21:16 ` Rafael J. Wysocki
2010-04-29 21:16 ` Rafael J. Wysocki
2010-04-30 4:24 ` Tejun Heo
2010-04-30 4:24 ` Tejun Heo
2010-04-30 17:26 ` Oleg Nesterov
2010-04-30 17:26 ` Oleg Nesterov
2010-05-20 8:30 ` Tejun Heo
2010-05-20 8:30 ` Tejun Heo
2010-05-20 22:27 ` Rafael J. Wysocki
2010-05-20 22:27 ` Rafael J. Wysocki
2010-05-21 6:35 ` Tejun Heo
2010-05-21 6:35 ` Tejun Heo
2010-05-06 15:18 ` Alan Stern
2010-05-06 15:18 ` Alan Stern
2010-05-06 19:28 ` Rafael J. Wysocki
2010-05-06 19:28 ` Rafael J. Wysocki
2010-05-06 19:40 ` Alan Stern
2010-05-06 19:40 ` Alan Stern
2010-05-06 23:48 ` Arve Hjønnevåg
2010-05-06 23:48 ` Arve Hjønnevåg
2010-05-07 14:22 ` Alan Stern
2010-05-07 14:22 ` Alan Stern
2010-04-28 4:31 ` Arve Hjønnevåg
-- strict thread matches above, loose matches on Subject: below --
2010-04-30 22:36 [PATCH 0/8] Suspend block api (version 6) Arve Hjønnevåg
2010-04-30 22:36 ` [PATCH 1/8] PM: Add suspend block api Arve Hjønnevåg
2010-04-30 22:36 ` [PATCH 2/8] PM: suspend_block: Add driver to access suspend blockers from user-space Arve Hjønnevåg
2010-04-30 22:36 ` [PATCH 3/8] PM: suspend_block: Abort task freezing if a suspend_blocker is active Arve Hjønnevåg
2010-04-30 22:36 ` [PATCH 4/8] PM: suspend_block: Add debugfs file Arve Hjønnevåg
2010-04-30 22:36 ` [PATCH 5/8] PM: suspend_block: Add suspend_blocker stats Arve Hjønnevåg
2010-04-30 22:36 ` [PATCH 6/8] PM: Add suspend blocking work Arve Hjønnevåg
2010-04-30 22:36 ` Arve Hjønnevåg
2010-05-01 6:14 ` Tejun Heo
2010-05-01 6:14 ` Tejun Heo
2010-05-02 7:05 ` Pavel Machek
2010-05-02 7:05 ` Pavel Machek
2010-05-14 4:11 [PATCH 0/8] Suspend block api (version 7) Arve Hjønnevåg
2010-05-14 4:11 ` [PATCH 1/8] PM: Add suspend block api Arve Hjønnevåg
2010-05-14 4:11 ` [PATCH 2/8] PM: suspend_block: Add driver to access suspend blockers from user-space Arve Hjønnevåg
2010-05-14 4:11 ` [PATCH 3/8] PM: suspend_block: Abort task freezing if a suspend_blocker is active Arve Hjønnevåg
2010-05-14 4:11 ` [PATCH 4/8] PM: suspend_block: Add debugfs file Arve Hjønnevåg
2010-05-14 4:11 ` [PATCH 5/8] PM: suspend_block: Add suspend_blocker stats Arve Hjønnevåg
2010-05-14 4:11 ` [PATCH 6/8] PM: Add suspend blocking work Arve Hjønnevåg
2010-05-14 4:11 ` Arve Hjønnevåg
2010-05-21 22:46 [PATCH 0/8] Suspend block api (version 8) Arve Hjønnevåg
2010-05-21 22:46 ` [PATCH 1/8] PM: Opportunistic suspend support Arve Hjønnevåg
2010-05-21 22:46 ` [PATCH 2/8] PM: suspend_block: Add driver to access suspend blockers from user-space Arve Hjønnevåg
2010-05-21 22:46 ` [PATCH 3/8] PM: suspend_block: Abort task freezing if a suspend_blocker is active Arve Hjønnevåg
2010-05-21 22:46 ` [PATCH 4/8] PM: suspend_block: Add debugfs file Arve Hjønnevåg
2010-05-21 22:46 ` [PATCH 5/8] PM: suspend_block: Add suspend_blocker stats Arve Hjønnevåg
2010-05-21 22:46 ` [PATCH 6/8] PM: Add suspend blocking work Arve Hjønnevåg
2010-05-21 22:46 ` Arve Hjønnevåg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD7E144.6050608@kernel.org \
--to=tj@kernel.org \
--cc=arve@android.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.