* [U-Boot] [PATCH] MX31: Adjust default environment for QONG module @ 2010-04-28 11:58 Stefano Babic 2010-04-28 15:29 ` Wolfgang Denk 2010-04-28 16:45 ` [U-Boot] [PATCH V2] " Stefano Babic 0 siblings, 2 replies; 4+ messages in thread From: Stefano Babic @ 2010-04-28 11:58 UTC (permalink / raw) To: u-boot Because the the size of u-boot increased after adding new features (mainly the support for ubi/ubifs), storing u-boot requires an additional sector on the flash. The patch adjusts the kernel_addr and mtdparts variables giving 128KB more space for u-boot code. Signed-off-by: Stefano Babic <sbabic@denx.de> --- include/configs/qong.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/qong.h b/include/configs/qong.h index 1a2f19f..067dc79 100644 --- a/include/configs/qong.h +++ b/include/configs/qong.h @@ -144,7 +144,7 @@ "addmtd=setenv bootargs ${bootargs} ${mtdparts}\0" \ "addmisc=setenv bootargs ${bootargs}\0" \ "uboot_addr=a0000000\0" \ - "kernel_addr=a0080000\0" \ + "kernel_addr=a00a0000\0" \ "ramdisk_addr=a0300000\0" \ "u-boot=qong/u-boot.bin\0" \ "kernel_addr_r=80800000\0" \ @@ -274,7 +274,7 @@ extern int qong_nand_rdy(void *chip); #define CONFIG_FLASH_CFI_MTD #define MTDIDS_DEFAULT "nor0=physmap-flash.0" #define MTDPARTS_DEFAULT \ - "mtdparts=physmap-flash.0:256k(U-Boot),128k(env1)," \ + "mtdparts=physmap-flash.0:384k(U-Boot),128k(env1)," \ "128k(env2),2560k(kernel),13m(ramdisk),-(user)" #endif /* __CONFIG_H */ -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] MX31: Adjust default environment for QONG module 2010-04-28 11:58 [U-Boot] [PATCH] MX31: Adjust default environment for QONG module Stefano Babic @ 2010-04-28 15:29 ` Wolfgang Denk 2010-04-28 16:10 ` Stefano Babic 2010-04-28 16:45 ` [U-Boot] [PATCH V2] " Stefano Babic 1 sibling, 1 reply; 4+ messages in thread From: Wolfgang Denk @ 2010-04-28 15:29 UTC (permalink / raw) To: u-boot Dear Stefano Babic, In message <1272455915-1143-1-git-send-email-sbabic@denx.de> you wrote: > Because the the size of u-boot increased after adding > new features (mainly the support for ubi/ubifs), storing > u-boot requires an additional sector on the flash. The patch > adjusts the kernel_addr and mtdparts variables giving 128KB > more space for u-boot code. ... > @@ -144,7 +144,7 @@ > "addmtd=setenv bootargs ${bootargs} ${mtdparts}\0" \ > "addmisc=setenv bootargs ${bootargs}\0" \ > "uboot_addr=a0000000\0" \ > - "kernel_addr=a0080000\0" \ > + "kernel_addr=a00a0000\0" \ > "ramdisk_addr=a0300000\0" \ =========^^^^^^^^^^^^^^^^^^^^^ > "u-boot=qong/u-boot.bin\0" \ > "kernel_addr_r=80800000\0" \ > @@ -274,7 +274,7 @@ extern int qong_nand_rdy(void *chip); > #define CONFIG_FLASH_CFI_MTD > #define MTDIDS_DEFAULT "nor0=physmap-flash.0" > #define MTDPARTS_DEFAULT \ > - "mtdparts=physmap-flash.0:256k(U-Boot),128k(env1)," \ > + "mtdparts=physmap-flash.0:384k(U-Boot),128k(env1)," \ > "128k(env2),2560k(kernel),13m(ramdisk),-(user)" This shifts the start address of the "ramdisk' and "user" partitions to some odd addresses; also, this makes the definition of "ramdisk_addr" (see above) incorrct. I recommend to do this instead: - "mtdparts=physmap-flash.0:256k(U-Boot),128k(env1)," \ - "128k(env2),2560k(kernel),13m(ramdisk),-(user)" + "mtdparts=physmap-flash.0:384k(U-Boot),128k(env1)," \ + "128k(env2),2432k(kernel),13m(ramdisk),-(user)" What do you think? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de People seldom know what they want until you give them what they ask for. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] MX31: Adjust default environment for QONG module 2010-04-28 15:29 ` Wolfgang Denk @ 2010-04-28 16:10 ` Stefano Babic 0 siblings, 0 replies; 4+ messages in thread From: Stefano Babic @ 2010-04-28 16:10 UTC (permalink / raw) To: u-boot Wolfgang Denk wrote: >> "ramdisk_addr=a0300000\0" \ > =========^^^^^^^^^^^^^^^^^^^^^ > >> "u-boot=qong/u-boot.bin\0" \ >> "kernel_addr_r=80800000\0" \ >> @@ -274,7 +274,7 @@ extern int qong_nand_rdy(void *chip); >> #define CONFIG_FLASH_CFI_MTD >> #define MTDIDS_DEFAULT "nor0=physmap-flash.0" >> #define MTDPARTS_DEFAULT \ >> - "mtdparts=physmap-flash.0:256k(U-Boot),128k(env1)," \ >> + "mtdparts=physmap-flash.0:384k(U-Boot),128k(env1)," \ >> "128k(env2),2560k(kernel),13m(ramdisk),-(user)" > > This shifts the start address of the "ramdisk' and "user" partitions > to some odd addresses; also, this makes the definition of > "ramdisk_addr" (see above) incorrct. You are right. The ramdisk_addr must be shifted, or the kernel size must be adjusted. > I recommend to do this instead: > > - "mtdparts=physmap-flash.0:256k(U-Boot),128k(env1)," \ > - "128k(env2),2560k(kernel),13m(ramdisk),-(user)" > + "mtdparts=physmap-flash.0:384k(U-Boot),128k(env1)," \ > + "128k(env2),2432k(kernel),13m(ramdisk),-(user)" > > > What do you think? Agree. I will send a new version of the patch with your proposed values. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH V2] MX31: Adjust default environment for QONG module 2010-04-28 11:58 [U-Boot] [PATCH] MX31: Adjust default environment for QONG module Stefano Babic 2010-04-28 15:29 ` Wolfgang Denk @ 2010-04-28 16:45 ` Stefano Babic 1 sibling, 0 replies; 4+ messages in thread From: Stefano Babic @ 2010-04-28 16:45 UTC (permalink / raw) To: u-boot Because the the size of u-boot increased after adding new features (mainly the support for ubi/ubifs), storing u-boot requires an additional sector on the flash. The patch adjusts the kernel_addr and mtdparts variable giving 128KB more space for u-boot code. Signed-off-by: Stefano Babic <sbabic@denx.de> --- include/configs/qong.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/configs/qong.h b/include/configs/qong.h index 1284a00..dc828f6 100644 --- a/include/configs/qong.h +++ b/include/configs/qong.h @@ -144,7 +144,7 @@ "addmtd=setenv bootargs ${bootargs} ${mtdparts}\0" \ "addmisc=setenv bootargs ${bootargs}\0" \ "uboot_addr=a0000000\0" \ - "kernel_addr=a0080000\0" \ + "kernel_addr=a00a0000\0" \ "ramdisk_addr=a0300000\0" \ "u-boot=qong/u-boot.bin\0" \ "kernel_addr_r=80800000\0" \ @@ -276,7 +276,7 @@ extern int qong_nand_rdy(void *chip); #define CONFIG_FLASH_CFI_MTD #define MTDIDS_DEFAULT "nor0=physmap-flash.0" #define MTDPARTS_DEFAULT \ - "mtdparts=physmap-flash.0:256k(U-Boot),128k(env1)," \ - "128k(env2),2560k(kernel),13m(ramdisk),-(user)" + "mtdparts=physmap-flash.0:384k(U-Boot),128k(env1)," \ + "128k(env2),2432k(kernel),13m(ramdisk),-(user)" #endif /* __CONFIG_H */ -- 1.6.3.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-04-28 16:45 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-04-28 11:58 [U-Boot] [PATCH] MX31: Adjust default environment for QONG module Stefano Babic 2010-04-28 15:29 ` Wolfgang Denk 2010-04-28 16:10 ` Stefano Babic 2010-04-28 16:45 ` [U-Boot] [PATCH V2] " Stefano Babic
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.