From: Michal Simek <monstr@monstr.eu>
To: "Steven J. Magnani" <steve@digidescorp.com>
Cc: microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][NOMMU] microblaze: re-enable interrupts before calling schedule
Date: Fri, 30 Apr 2010 07:56:50 +0200 [thread overview]
Message-ID: <4BDA7122.6080509@monstr.eu> (raw)
In-Reply-To: <1272391223-32012-1-git-send-email-steve@digidescorp.com>
Steven J. Magnani wrote:
> schedule() should not be called with interrupts disabled.
>
> Signed-off-by: Steven J. Magnani <steve@digidescorp.com>
> ---
> diff -uprN a/arch/microblaze/kernel/entry-nommu.S b/arch/microblaze/kernel/entry-nommu.S
> --- a/arch/microblaze/kernel/entry-nommu.S 2010-04-27 10:14:33.000000000 -0500
> +++ b/arch/microblaze/kernel/entry-nommu.S 2010-04-27 12:53:04.000000000 -0500
> @@ -476,6 +476,8 @@ ENTRY(ret_from_fork)
> nop
>
> work_pending:
> + enable_irq
> +
> andi r11, r19, _TIF_NEED_RESCHED
> beqi r11, 1f
> bralid r15, schedule
>
Applied
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
prev parent reply other threads:[~2010-04-30 19:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 18:00 [PATCH][NOMMU] microblaze: re-enable interrupts before calling schedule Steven J. Magnani
2010-04-30 5:56 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDA7122.6080509@monstr.eu \
--to=monstr@monstr.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=steve@digidescorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.