* [PATCH][NOMMU] microblaze: re-enable interrupts before calling schedule
@ 2010-04-27 18:00 Steven J. Magnani
2010-04-30 5:56 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Steven J. Magnani @ 2010-04-27 18:00 UTC (permalink / raw)
To: microblaze-uclinux; +Cc: monstr, linux-kernel, Steven J. Magnani
schedule() should not be called with interrupts disabled.
Signed-off-by: Steven J. Magnani <steve@digidescorp.com>
---
diff -uprN a/arch/microblaze/kernel/entry-nommu.S b/arch/microblaze/kernel/entry-nommu.S
--- a/arch/microblaze/kernel/entry-nommu.S 2010-04-27 10:14:33.000000000 -0500
+++ b/arch/microblaze/kernel/entry-nommu.S 2010-04-27 12:53:04.000000000 -0500
@@ -476,6 +476,8 @@ ENTRY(ret_from_fork)
nop
work_pending:
+ enable_irq
+
andi r11, r19, _TIF_NEED_RESCHED
beqi r11, 1f
bralid r15, schedule
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][NOMMU] microblaze: re-enable interrupts before calling schedule
2010-04-27 18:00 [PATCH][NOMMU] microblaze: re-enable interrupts before calling schedule Steven J. Magnani
@ 2010-04-30 5:56 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2010-04-30 5:56 UTC (permalink / raw)
To: Steven J. Magnani; +Cc: microblaze-uclinux, linux-kernel
Steven J. Magnani wrote:
> schedule() should not be called with interrupts disabled.
>
> Signed-off-by: Steven J. Magnani <steve@digidescorp.com>
> ---
> diff -uprN a/arch/microblaze/kernel/entry-nommu.S b/arch/microblaze/kernel/entry-nommu.S
> --- a/arch/microblaze/kernel/entry-nommu.S 2010-04-27 10:14:33.000000000 -0500
> +++ b/arch/microblaze/kernel/entry-nommu.S 2010-04-27 12:53:04.000000000 -0500
> @@ -476,6 +476,8 @@ ENTRY(ret_from_fork)
> nop
>
> work_pending:
> + enable_irq
> +
> andi r11, r19, _TIF_NEED_RESCHED
> beqi r11, 1f
> bralid r15, schedule
>
Applied
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-30 19:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-27 18:00 [PATCH][NOMMU] microblaze: re-enable interrupts before calling schedule Steven J. Magnani
2010-04-30 5:56 ` Michal Simek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.