From: Avi Kivity <avi@redhat.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
jslaby@suse.cz, akpm@linux-foundation.org,
paulmck@linux.vnet.ibm.com, adobriyan@gmail.com, mingo@elte.hu,
peterz@infradead.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: use kmalloc() to allocate fdmem if possible
Date: Mon, 03 May 2010 10:42:30 +0300 [thread overview]
Message-ID: <4BDE7E66.8030509@redhat.com> (raw)
In-Reply-To: <y2z412e6f7f1005030005vc3be4977z3add08bfc72d1c44@mail.gmail.com>
On 05/03/2010 10:05 AM, Changli Gao wrote:
> On Mon, May 3, 2010 at 2:06 PM, Avi Kivity<avi@redhat.com> wrote:
>
>> My point is, vmalloc() and vfree should do this, not their callers:
>>
>> vmalloc(size):
>> if (size<= PAGE_SIZE)
>> return kmalloc(size, GFP_KERNEL);
>> ...
>>
>> vfree(p):
>> if (!is_vmalloc_addr(p) {
>> kfree(p);
>> return;
>> }
>> ...
>>
> I think we should not change vmalloc/vfree, and you can invent new
> memory APIs, such as malloc()/free().
>
Why?
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-05-03 7:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Alexander Viro <viro@zeniv.linux.org.uk>
2010-05-02 16:46 ` [PATCH] fs: use kmalloc() to allocate fdmem if possible Changli Gao
2010-05-02 17:31 ` Avi Kivity
2010-05-03 0:15 ` Tetsuo Handa
2010-05-03 6:06 ` Avi Kivity
2010-05-03 7:05 ` Changli Gao
2010-05-03 7:05 ` Changli Gao
2010-05-03 7:42 ` Avi Kivity [this message]
2010-05-03 7:52 ` Changli Gao
2010-05-03 7:52 ` Changli Gao
2010-05-03 8:49 ` Avi Kivity
2010-05-03 9:03 ` Jiri Slaby
2010-05-03 9:18 ` Avi Kivity
2010-05-03 9:22 ` Jiri Slaby
2010-05-03 9:25 ` Jiri Slaby
2010-05-03 9:28 ` Avi Kivity
2010-05-03 9:13 ` Eric Dumazet
2010-05-03 9:19 ` Jiri Slaby
2010-05-03 9:29 ` Eric Dumazet
2010-05-03 9:29 ` Eric Dumazet
2010-05-04 4:20 ` Changli Gao
2010-05-04 5:33 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDE7E66.8030509@redhat.com \
--to=avi@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jslaby@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.