[PATCH 8/12] gdium uses different freq of mclk&m1xclk of sm501

[PATCH 8/12] gdium uses different freq of mclk&m1xclk of sm501

[yajin]

Gdium uses different freq of mclk&m1xclk of sm501. This seems a dirty
hack. Maybe we need a configuration option for changing the freq of
these clocks.

Signed-off-by: yajin <yajin@vm-kernel.org>
---
 drivers/mfd/sm501.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
index ce5dfce..5e55cbd 100644
--- a/drivers/mfd/sm501.c
+++ b/drivers/mfd/sm501.c
@@ -1606,10 +1606,15 @@ static struct sm501_initdata sm501_pci_initdata = {
 	.devices	= SM501_USE_ALL,

 	/* Errata AB-3 says that 72MHz is the fastest available
-	 * for 33MHZ PCI with proper bus-mastering operation */
-
+	 * for 33MHZ PCI with proper bus-mastering operation
+	 * For gdium, it works under 84&112M clock freq.*/
+#ifdef CONFIG_DEXXON_GDIUM
+	.mclk		= 84 * MHZ,
+	.m1xclk		= 112 * MHZ,
+#else
 	.mclk		= 72 * MHZ,
 	.m1xclk		= 144 * MHZ,
+#endif
 };

 static struct sm501_platdata_fbsub sm501_pdata_fbsub = {
-- 
1.5.6.5

Re: [PATCH 8/12] gdium uses different freq of mclk&m1xclk of sm501

[Sergei Shtylyov]

Hello.

yajin wrote:

> Gdium uses different freq of mclk&m1xclk of sm501. This seems a dirty
> hack. Maybe we need a configuration option for changing the freq of
> these clocks.
>
> Signed-off-by: yajin <yajin@vm-kernel.org>
> ---
>  drivers/mfd/sm501.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index ce5dfce..5e55cbd 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -1606,10 +1606,15 @@ static struct sm501_initdata sm501_pci_initdata = {
>  	.devices	= SM501_USE_ALL,
>
>  	/* Errata AB-3 says that 72MHz is the fastest available
> -	 * for 33MHZ PCI with proper bus-mastering operation */
> -
> +	 * for 33MHZ PCI with proper bus-mastering operation
> +	 * For gdium, it works under 84&112M clock freq.*/
>   

   According to CodingStyle, style of multiline comments should 
preferably be:

/*
 * bla
 * bla
 * bla
 */

WBR, Sergei

Re: [PATCH 8/12] gdium uses different freq of mclk&m1xclk of sm501

[Ben Dooks]

On 04/05/10 18:55, yajin wrote:
> Gdium uses different freq of mclk&m1xclk of sm501. This seems a dirty
> hack. Maybe we need a configuration option for changing the freq of
> these clocks.
> 
> Signed-off-by: yajin <yajin@vm-kernel.org>
> ---
>  drivers/mfd/sm501.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index ce5dfce..5e55cbd 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -1606,10 +1606,15 @@ static struct sm501_initdata sm501_pci_initdata = {
>  	.devices	= SM501_USE_ALL,
> 
>  	/* Errata AB-3 says that 72MHz is the fastest available
> -	 * for 33MHZ PCI with proper bus-mastering operation */
> -
> +	 * for 33MHZ PCI with proper bus-mastering operation
> +	 * For gdium, it works under 84&112M clock freq.*/
> +#ifdef CONFIG_DEXXON_GDIUM
> +	.mclk		= 84 * MHZ,
> +	.m1xclk		= 112 * MHZ,
> +#else

I think these frequencies are out of spec for the SM501,
Plus, it is a hack.
Does it not work at 72/144?

>  	.mclk		= 72 * MHZ,
>  	.m1xclk		= 144 * MHZ,
> +#endif
>  };
> 
>  static struct sm501_platdata_fbsub sm501_pdata_fbsub = {

Re: [PATCH 8/12] gdium uses different freq of mclk&m1xclk of sm501

[yajin]

Hi,


2010/5/25 Ben Dooks <ben@simtec.co.uk>:
> On 04/05/10 18:55, yajin wrote:
>> Gdium uses different freq of mclk&m1xclk of sm501. This seems a dirty
>> hack. Maybe we need a configuration option for changing the freq of
>> these clocks.
>>
>> Signed-off-by: yajin <yajin@vm-kernel.org>
>> ---
>>  drivers/mfd/sm501.c |    9 +++++++--
>>  1 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
>> index ce5dfce..5e55cbd 100644
>> --- a/drivers/mfd/sm501.c
>> +++ b/drivers/mfd/sm501.c
>> @@ -1606,10 +1606,15 @@ static struct sm501_initdata sm501_pci_initdata = {
>>       .devices        = SM501_USE_ALL,
>>
>>       /* Errata AB-3 says that 72MHz is the fastest available
>> -      * for 33MHZ PCI with proper bus-mastering operation */
>> -
>> +      * for 33MHZ PCI with proper bus-mastering operation
>> +      * For gdium, it works under 84&112M clock freq.*/
>> +#ifdef CONFIG_DEXXON_GDIUM
>> +     .mclk           = 84 * MHZ,
>> +     .m1xclk         = 112 * MHZ,
>> +#else
>
> I think these frequencies are out of spec for the SM501,
> Plus, it is a hack.
> Does it not work at 72/144?
>

I have asked the similar question on loongson-dev mail list[1]. If the
mclk clock freq is set to 72M, the LCD output has some problem. But it
works well on 84M freq. Maybe Arnaud knows the reason.


[1] http://groups.google.com/group/loongson-dev/browse_thread/thread/6233a6cb67dc02d2?hl=en_US