From: Yang Hongyang <yanghy@cn.fujitsu.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 3/3]xl: Add command description to command table
Date: Wed, 05 May 2010 08:47:22 +0800 [thread overview]
Message-ID: <4BE0C01A.9080900@cn.fujitsu.com> (raw)
In-Reply-To: <C80607EC.134A0%keir.fraser@eu.citrix.com>
Hi Keir,
On 05/05/2010 12:20 AM, Keir Fraser wrote:
> On 04/05/2010 17:10, "Ian Jackson" <Ian.Jackson@eu.citrix.com> wrote:
>
>>> +extern struct cmd_spec cmd_table[];
>>> +extern int cmdtable_len;
>>> +
>>> extern struct libxl_ctx ctx;
>>> extern int logfile;
>>
>> This is wrong. Use of "extern" in this way in a .c file is incorrect;
>> pure predeclarations should appear only in .h files, and they should
>> appear exactly once each. That way they can't get out of step.
>>
>> I'll send a patch to fix this at some point.
>
> I fixed it before I applied it.
Thank you for that!
>
> -- Keir
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>
--
Regards
Yang Hongyang
prev parent reply other threads:[~2010-05-05 0:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 9:24 [PATCH 3/3]xl: Add command description to command table Yang Hongyang
2010-05-04 16:10 ` Ian Jackson
2010-05-04 16:20 ` Keir Fraser
2010-05-04 16:41 ` Ian Jackson
2010-05-05 0:47 ` Yang Hongyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE0C01A.9080900@cn.fujitsu.com \
--to=yanghy@cn.fujitsu.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.