From: Yang Hongyang <yanghy@cn.fujitsu.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH]xl: move libxl init functions from xl.c to xl_cmdimpl.c
Date: Thu, 06 May 2010 09:12:38 +0800 [thread overview]
Message-ID: <4BE21786.40609@cn.fujitsu.com> (raw)
In-Reply-To: <19425.39634.19846.441503@mariner.uk.xensource.com>
Hi Ian,
On 05/06/2010 12:20 AM, Ian Jackson wrote:
> Yang Hongyang writes ("[Xen-devel] [PATCH]xl: move libxl init functions from xl.c to xl_cmdimpl.c"):
>> Move libxl init functions from xl.c to xl_cmdimpl.c, use a wrapper function
>> xl_init to do libxl init things.
>
> I don't understand the purpose of this change.
It's my mistake that uses extern vars in .c file this way, Keir fix part of it, but there remains
two declarations in xl.c. My prupose is to correct this usage. But compare to move these
declarations to .h file, I prefer move code related to these vars to xl_cmdimpl.c, because
I think the libxl init and set log functions is more related to command implementations.
>
> Ian.
>
>
--
Regards
Yang Hongyang
prev parent reply other threads:[~2010-05-06 1:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 4:42 [PATCH]xl: move libxl init functions from xl.c to xl_cmdimpl.c Yang Hongyang
2010-05-05 16:20 ` Ian Jackson
2010-05-06 1:12 ` Yang Hongyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE21786.40609@cn.fujitsu.com \
--to=yanghy@cn.fujitsu.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.