From: Gihan Munasinghe <GMunasinghe@flexiant.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] vncpassword support in libxl
Date: Thu, 06 May 2010 17:10:49 +0100 [thread overview]
Message-ID: <4BE2EA09.5030607@flexiant.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1005061701180.11380@kaball-desktop>
Stefano Stabellini wrote:
> On Thu, 6 May 2010, Gihan Munasinghe wrote:
>
>> Guys
>>
>> When trying to move xen4.0 and libxl I found that libxl does not support
>> vncpassword with in the device model.
>> Was there are particular reason this feature is not implemented . To get
>> our vms ported in to xen4 and to change our management stack to use
>> libxl. I have done the following patch what do you guys think.
>>
>> Thanks
>> Gihan
>>
>>
>>
>
> The indentation is often wrong and sometimes you are adding\removing
> blank lines for no reason.
> But apart from this small cosmetic issues the patch looks good.
>
Cool, I'll do the cosmetic changes and resubmit the patch
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>
>
next prev parent reply other threads:[~2010-05-06 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 15:01 [PATHCH] vncpassword support in libxl Gihan Munasinghe
2010-05-06 15:45 ` [PATCH] " Gihan Munasinghe
2010-05-06 16:02 ` Stefano Stabellini
2010-05-06 16:10 ` Ian Jackson
2010-05-06 16:12 ` Gihan Munasinghe
2010-05-06 16:10 ` Gihan Munasinghe [this message]
2010-05-06 16:07 ` Ian Jackson
2010-05-06 19:48 ` Gihan Munasinghe
2010-05-07 10:02 ` Ian Jackson
2010-05-07 10:37 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE2EA09.5030607@flexiant.com \
--to=gmunasinghe@flexiant.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.