All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gihan Munasinghe <GMunasinghe@flexiant.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] vncpassword support in libxl
Date: Thu, 06 May 2010 17:12:38 +0100	[thread overview]
Message-ID: <4BE2EA76.4020005@flexiant.com> (raw)
In-Reply-To: <19426.59907.68893.972136@mariner.uk.xensource.com>

Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] vncpassword support in libxl"):
>   
>> The indentation is often wrong and sometimes you are adding\removing
>> blank lines for no reason.
>> But apart from this small cosmetic issues the patch looks good.
>>     
>
> You missed that he removed this line:
>
> -    printf("Parsing config file %s\n", config_file);
>
> This demonstrates why patches with spurious stuff in should be
> rejected - it's too easy to miss a mistake when scanning past a lot of
> spurious changes.
>
> Ian.
>
>
>   
Yes my mad will do the changes and resubmit again

  reply	other threads:[~2010-05-06 16:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-06 15:01 [PATHCH] vncpassword support in libxl Gihan Munasinghe
2010-05-06 15:45 ` [PATCH] " Gihan Munasinghe
2010-05-06 16:02   ` Stefano Stabellini
2010-05-06 16:10     ` Ian Jackson
2010-05-06 16:12       ` Gihan Munasinghe [this message]
2010-05-06 16:10     ` Gihan Munasinghe
2010-05-06 16:07   ` Ian Jackson
2010-05-06 19:48     ` Gihan Munasinghe
2010-05-07 10:02       ` Ian Jackson
2010-05-07 10:37         ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE2EA76.4020005@flexiant.com \
    --to=gmunasinghe@flexiant.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.