From: Avi Kivity <avi@redhat.com>
To: "Xu, Dongxiao" <dongxiao.xu@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH 4/4 v3] KVM: VMX: VMXON/VMXOFF usage changes.
Date: Tue, 11 May 2010 12:50:21 +0300 [thread overview]
Message-ID: <4BE9285D.6070006@redhat.com> (raw)
In-Reply-To: <D5AB6E638E5A3E4B8F4406B113A5A19A1E6E8833@shsmsx501.ccr.corp.intel.com>
On 05/11/2010 12:38 PM, Xu, Dongxiao wrote:
>
>> I'm not sure why this is needed. vmx_cpuid_update() is called from a
>> vcpu ioctl which should have called vcpu_load() before.
>>
>> Apart from that, everything looks good for merging.
>>
> Vcpu_load() and vcpu_put() is not called in that ioctl. I will add that and
> send out another version of patchset.
>
That's a serious bug even before this patchset, since vmx_cpuid_update
accesses the vmcs. Please send the fix as a separate patch (which will
be backported to -stable).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-05-11 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 2:43 [PATCH 4/4 v3] KVM: VMX: VMXON/VMXOFF usage changes Xu, Dongxiao
2010-05-11 9:05 ` Avi Kivity
2010-05-11 9:38 ` Xu, Dongxiao
2010-05-11 9:50 ` Avi Kivity [this message]
2010-05-11 9:54 ` Xu, Dongxiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE9285D.6070006@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=dongxiao.xu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.