From: "H. Peter Anvin" <hpa@zytor.com>
To: Joe Perches <joe@perches.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Jiri Kosina <trivial@kernel.org>
Subject: Re: [trivial PATCH] arch/x86: Remove unnecessary returns from void function()'s
Date: Tue, 11 May 2010 17:41:46 -0700 [thread overview]
Message-ID: <4BE9F94A.9000907@zytor.com> (raw)
In-Reply-To: <1273624747.20514.316.camel@Joe-Laptop.home>
On 05/11/2010 05:39 PM, Joe Perches wrote:
> This patch removes from arch/x86/ all the unnecessary
> return; statements that precede the last closing brace of
> void functions.
>
> It does not remove returns that are immediately
> preceded by a label as gcc doesn't like that.
And the point of this is?
I fail to see how this improves the clarity of the code one iota, and
isn't anything but just churn.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-05-12 0:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 0:39 [trivial PATCH] arch/x86: Remove unnecessary returns from void function()'s Joe Perches
2010-05-12 0:41 ` H. Peter Anvin [this message]
2010-05-12 1:00 ` Joe Perches
2010-05-12 1:53 ` Joe Perches
2010-05-12 3:37 ` H. Peter Anvin
2010-05-12 3:51 ` Joe Perches
2010-05-12 3:58 ` H. Peter Anvin
2010-05-12 4:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE9F94A.9000907@zytor.com \
--to=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.