From: "H. Peter Anvin" <hpa@zytor.com>
To: Joe Perches <joe@perches.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Jiri Kosina <trivial@kernel.org>
Subject: Re: [trivial PATCH] arch/x86: Remove unnecessary returns from void function()'s
Date: Tue, 11 May 2010 20:37:17 -0700 [thread overview]
Message-ID: <4BEA226D.3080103@zytor.com> (raw)
In-Reply-To: <1273629234.20514.333.camel@Joe-Laptop.home>
On 05/11/2010 06:53 PM, Joe Perches wrote:
>
> Just a stat from arch/x86:
>
> There may be a little over 2000 void functions in arch/x86/,
> 40 use returns before the trailing brace.
>
> Call it churn or consistency, <shrug>.
>
No, please get something straight:
Consistency is not an end in itself. Readability is, however.
Avoiding churn, however, is *also* an end in itself. Sometimes churn is
motivated by an increase in readability. Churn is *not* motivated just
for "consistency" unless it improves readability.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-05-12 3:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 0:39 [trivial PATCH] arch/x86: Remove unnecessary returns from void function()'s Joe Perches
2010-05-12 0:41 ` H. Peter Anvin
2010-05-12 1:00 ` Joe Perches
2010-05-12 1:53 ` Joe Perches
2010-05-12 3:37 ` H. Peter Anvin [this message]
2010-05-12 3:51 ` Joe Perches
2010-05-12 3:58 ` H. Peter Anvin
2010-05-12 4:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEA226D.3080103@zytor.com \
--to=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.