[PATCH 2/2]xl: Add "xl top" command

[PATCH 2/2]xl: Add "xl top" command

[Yang Hongyang]

Add "xl top" command, a clone of "xm top".

Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>

diff -r feb1b75800d6 -r 0efa1c583fb0 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Wed May 12 18:35:58 2010 +0800
+++ b/tools/libxl/xl_cmdimpl.c	Wed May 12 18:47:12 2010 +0800
@@ -3098,3 +3098,23 @@
 
     exit(0);
 }
+
+int main_top(int argc, char **argv)
+{
+    int opt;
+
+    while ((opt = getopt(argc, argv, "h")) != -1) {
+        switch (opt) {
+        case 'h':
+            help("top");
+            exit(0);
+        default:
+            fprintf(stderr, "option `%c' not supported.\n", opt);
+            break;
+        }
+    }
+
+    system("xentop");
+
+    exit(0);
+}
diff -r feb1b75800d6 -r 0efa1c583fb0 tools/libxl/xl_cmdimpl.h
--- a/tools/libxl/xl_cmdimpl.h	Wed May 12 18:35:58 2010 +0800
+++ b/tools/libxl/xl_cmdimpl.h	Wed May 12 18:47:12 2010 +0800
@@ -40,5 +40,6 @@
 int main_rename(int argc, char **argv);
 int main_trigger(int argc, char **argv);
 int main_sysrq(int argc, char **argv);
+int main_top(int argc, char **argv);
 
 void help(char *command);
diff -r feb1b75800d6 -r 0efa1c583fb0 tools/libxl/xl_cmdtable.c
--- a/tools/libxl/xl_cmdtable.c	Wed May 12 18:35:58 2010 +0800
+++ b/tools/libxl/xl_cmdtable.c	Wed May 12 18:47:12 2010 +0800
@@ -177,6 +177,11 @@
       "Send a sysrq to a domain",
       "<Domain> <letter>",
     },
+    { "top",
+      &main_top,
+      "Monitor a host and the domains in real time",
+      "",
+    },
 };
 
 int cmdtable_len = sizeof(cmd_table)/sizeof(struct cmd_spec);

-- 
Regards
Yang Hongyang

Re: [PATCH 2/2]xl: Add "xl top" command

[Ian Jackson]

Yang Hongyang writes ("[Xen-devel] [PATCH 2/2]xl: Add "xl top" command"):
> Add "xl top" command, a clone of "xm top".
> 
> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>

This is mostly OK, but:

> +    system("xentop");

1. You should probably use execlp rather than system.
2. You do not check the return value.  This is a serious mistake.

Ian.