From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: aliguori@us.ibm.com, clalance@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Revive -version 'QEMU PC Emulator...'
Date: Wed, 12 May 2010 22:38:53 +0200 [thread overview]
Message-ID: <4BEB11DD.20601@redhat.com> (raw)
In-Reply-To: <1273696161-14332-1-git-send-email-crobinso@redhat.com>
On 05/12/10 22:29, Cole Robinson wrote:
> Commit f75ca1ae205f24dae296c82d534c37746f87232f changed the version
> string from:
>
> QEMU PC Emulator version x.yy.z
>
> to
>
> QEMU Emulator version x.yy.z
>
> libvirt is overly sensitive to the format of this string, and barfs when
> trying to parse qemu -help output. While libvirt should certainly be more
> robust here, changing the output format of -version for cosmetic reasons
> doesn't seem like the best idea, so let's revert the change and add a
> comment explaining the issue.
Rather than this, I would prefer a -version argument that just returns
the current QEMU version string.
IMHO it's not a good approach to do static string matching.
Cheers,
Jes
next prev parent reply other threads:[~2010-05-13 3:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 20:29 [Qemu-devel] [PATCH] Revive -version 'QEMU PC Emulator...' Cole Robinson
2010-05-12 20:38 ` Jes Sorensen [this message]
2010-05-12 20:48 ` [Qemu-devel] " Cole Robinson
2010-05-13 8:35 ` Jes Sorensen
2010-05-13 13:04 ` Cole Robinson
2010-05-13 13:07 ` Jes Sorensen
2010-05-13 13:21 ` Daniel P. Berrange
2010-05-13 13:38 ` Luiz Capitulino
2010-05-13 14:00 ` Paul Brook
2010-05-13 19:20 ` Blue Swirl
2010-05-13 21:24 ` Stuart Brady
2010-05-14 13:24 ` Anthony Liguori
2010-05-14 13:54 ` Daniel P. Berrange
2010-05-14 14:22 ` Anthony Liguori
2010-05-14 14:42 ` Daniel P. Berrange
2010-05-14 14:52 ` Anthony Liguori
2010-05-14 15:02 ` Daniel P. Berrange
2010-05-14 15:08 ` Anthony Liguori
2010-05-14 13:17 ` Anthony Liguori
2010-05-14 13:25 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEB11DD.20601@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=clalance@redhat.com \
--cc=crobinso@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.