From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Hiroshi Doyu <hiroshi.doyu@nokia.com>,
linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 03/15] omap: mailbox: 2420 should be detected at run-time
Date: Fri, 14 May 2010 14:17:10 +0400 [thread overview]
Message-ID: <4BED2326.4090302@ru.mvista.com> (raw)
In-Reply-To: <1273772856-10881-4-git-send-email-felipe.contreras@gmail.com>
Hello.
Felipe Contreras wrote:
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> arch/arm/mach-omap2/mailbox.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
> index 252e53b..6d17da8 100644
> --- a/arch/arm/mach-omap2/mailbox.c
> +++ b/arch/arm/mach-omap2/mailbox.c
> @@ -431,7 +431,8 @@ err_dsp:
> static int __devexit omap2_mbox_remove(struct platform_device *pdev)
> {
> #if defined(CONFIG_ARCH_OMAP2420)
> - omap_mbox_unregister(&mbox_iva_info);
> + if (cpu_is_omap2420())
> + omap_mbox_unregister(&mbox_iva_info);
> #endif
Shouldn't #ifdef be remove then?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/15] omap: mailbox: 2420 should be detected at run-time
Date: Fri, 14 May 2010 14:17:10 +0400 [thread overview]
Message-ID: <4BED2326.4090302@ru.mvista.com> (raw)
In-Reply-To: <1273772856-10881-4-git-send-email-felipe.contreras@gmail.com>
Hello.
Felipe Contreras wrote:
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> arch/arm/mach-omap2/mailbox.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
> index 252e53b..6d17da8 100644
> --- a/arch/arm/mach-omap2/mailbox.c
> +++ b/arch/arm/mach-omap2/mailbox.c
> @@ -431,7 +431,8 @@ err_dsp:
> static int __devexit omap2_mbox_remove(struct platform_device *pdev)
> {
> #if defined(CONFIG_ARCH_OMAP2420)
> - omap_mbox_unregister(&mbox_iva_info);
> + if (cpu_is_omap2420())
> + omap_mbox_unregister(&mbox_iva_info);
> #endif
Shouldn't #ifdef be remove then?
WBR, Sergei
next prev parent reply other threads:[~2010-05-14 10:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 17:47 [PATCH 00/15] omap: mailbox: reorganize init Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 01/15] omap: mailbox: trivial cleanups Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 02/15] omap: mailbox: reorganize structures Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 03/15] omap: mailbox: 2420 should be detected at run-time Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-14 10:17 ` Sergei Shtylyov [this message]
2010-05-14 10:17 ` Sergei Shtylyov
2010-05-14 10:47 ` Felipe Contreras
2010-05-14 10:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 04/15] omap: mailbox: use correct config for omap1 Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 05/15] omap: mailbox: update omap1 probing Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 06/15] omap: mailbox: reorganize registering Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 07/15] omap: mailbox: only compile for configured archs Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 08/15] omap: mailbox: reorganize omap platform_device Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 09/15] omap: mailbox: move more stuff to omap_mbox_init() Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 10/15] omap: mailbox: trivial sync between omap1 and 2 Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 11/15] omap: mailbox: split platform driver Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 12/15] omap: mailbox: always built-in platform data Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 13/15] omap: mailbox: reorganize headers Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 14/15] omap: mailbox: don't export unecessary symbols Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-13 17:47 ` [PATCH 15/15] omap: mailbox: mark some resources as __initdata Felipe Contreras
2010-05-13 17:47 ` Felipe Contreras
2010-05-14 9:12 ` [PATCH 00/15] omap: mailbox: reorganize init Hiroshi DOYU
2010-05-14 9:12 ` Hiroshi DOYU
2010-05-14 15:06 ` Felipe Contreras
2010-05-14 15:06 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BED2326.4090302@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=felipe.contreras@gmail.com \
--cc=hiroshi.doyu@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.