Re: [PATCH 1/2] wireless: rtl818x: rtl8180: add ids

Re: [PATCH 1/2] wireless: rtl818x: rtl8180: add ids

[Hin-Tak Leung]

--- On Sat, 15/5/10, Xose Vazquez Perez <xose.vazquez@gmail.com> wrote:
> taken from windows inf file
> 
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>

Acked-by: Hin-Tak Leung <htl10@users.sourceforge.net>

You added 3 device ids - do you own one of them by any chance? We like to know who has what hardware sometimes - just in case they are slightly different.

Hin-Tak


      

Re: [PATCH 1/2] wireless: rtl818x: rtl8180: add ids

[Xose Vazquez Perez]

On 05/15/2010 01:49 AM, Hin-Tak Leung wrote:

> --- On Sat, 15/5/10, Xose Vazquez Perez <xose.vazquez@gmail.com> wrote:
>> taken from windows inf file
>>
>> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> 
> Acked-by: Hin-Tak Leung <htl10@users.sourceforge.net>
> 
> You added 3 device ids - do you own one of them by any chance? We like to know who has what hardware sometimes - just in case they are slightly different.

Sorry, but no realtek devices here.
     
-- 
If less is more than more, most is more than less.

Re: [PATCH 1/2] wireless: rtl818x: rtl8180: add ids

[Hin-Tak Leung]

--- On Sat, 15/5/10, Xose Vazquez Perez <xose.vazquez@gmail.com> wrote:

> Sorry, but no realtek devices here.

I am sorry, if you do not own any of the devices for which you just copied a bunch of IDs from the windows driver, that means your patch is untested. What is your purpose of copying IDs from the windows driver? 

There is no code sharing between the windows driver and the linux driver, and there are at least 5 variants of the device - so what the windows driver supports really bears no relationship with what the linux driver supports.
I don't think it is a good idea to blindly copy IDs from the windows driver without testing.




      

[PATCH 1/2] wireless: rtl818x: rtl8180: add ids

[Xose Vazquez Perez]

taken from windows inf file

Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 drivers/net/wireless/rtl818x/rtl8180_dev.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/rtl818x/rtl8180_dev.c b/drivers/net/wireless/rtl818x/rtl8180_dev.c
index 4801589..6d6140d 100644
--- a/drivers/net/wireless/rtl818x/rtl8180_dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8180_dev.c
@@ -36,6 +36,7 @@ MODULE_LICENSE("GPL");
 
 static DEFINE_PCI_DEVICE_TABLE(rtl8180_table) = {
 	/* rtl8185 */
+	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8184) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8185) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_BELKIN, 0x700f) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_BELKIN, 0x701f) },
@@ -45,6 +46,8 @@ static DEFINE_PCI_DEVICE_TABLE(rtl8180_table) = {
 	{ PCI_DEVICE(0x1799, 0x6001) },
 	{ PCI_DEVICE(0x1799, 0x6020) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x3300) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x3301) },
+	{ PCI_DEVICE(0x1432, 0x7106) },
 	{ }
 };
 
-- 
1.6.6.1