From: Julian Pidancet <julian.pidancet@citrix.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Add QEMU DirectFB display driver
Date: Mon, 17 May 2010 13:04:10 +0100 [thread overview]
Message-ID: <4BF130BA.6050903@citrix.com> (raw)
In-Reply-To: <4BF12038.3010600@redhat.com>
On 05/17/2010 11:53 AM, Gerd Hoffmann wrote:
>> +directfb="no"
>
> Should be ="" (aka autodetect).
>
>> +if test "$directfb" = "yes" ; then
>> + directfb_libs=`directfb-config --libs`
>> + directfb_cflags=`directfb-config --cflags`
>> + libs_softmmu="$directfb_libs $libs_softmmu"
>> +fi
>
> use pkgconfig here. directfb-config most likely is just a pkgconfig
> wrapper anyway.
>
Unfortunately, directfb-config is not a pkgconfig wrapper, it is a standalone shell script.
Thus, I don't know if there is an easier way of "autodetecting" directfb than probing the directfb-config script.
--
Julian
next prev parent reply other threads:[~2010-05-17 12:04 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 16:58 [Qemu-devel] [PATCH] Add QEMU DirectFB display driver Julian Pidancet
2010-05-14 17:07 ` Anthony Liguori
2010-05-17 10:58 ` Gerd Hoffmann
2010-05-17 10:53 ` Gerd Hoffmann
2010-05-17 12:04 ` Julian Pidancet [this message]
2010-05-17 19:25 ` Gerd Hoffmann
2010-05-17 11:44 ` Christoph Hellwig
2010-05-17 12:14 ` Julian Pidancet
2010-05-17 12:35 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2010-05-14 16:20 Julian Pidancet
2010-05-13 15:53 Julian Pidancet
2010-05-16 1:10 ` Paul Brook
2010-05-16 1:14 ` Alexander Graf
2010-05-17 13:30 ` Anthony Liguori
2010-05-17 15:09 ` Julian Pidancet
2010-05-17 16:28 ` Anthony Liguori
2010-05-17 20:20 ` Gerd Hoffmann
2010-05-17 20:32 ` Anthony Liguori
2010-05-17 21:35 ` malc
2010-05-17 21:43 ` Anthony Liguori
2010-05-17 21:45 ` malc
2010-05-17 22:26 ` Alexander Graf
2010-05-17 22:42 ` malc
2010-05-17 22:47 ` Anthony Liguori
2010-05-17 22:55 ` Alexander Graf
2010-05-17 23:17 ` Anthony Liguori
2010-05-17 22:46 ` Anthony Liguori
2010-05-17 22:49 ` Alexander Graf
2010-05-17 22:54 ` Anthony Liguori
2010-05-17 22:59 ` Alexander Graf
2010-05-18 8:09 ` Kevin Wolf
2010-05-18 9:12 ` Stefano Stabellini
2010-05-18 9:23 ` Gerd Hoffmann
2010-05-18 9:29 ` Stefano Stabellini
2010-05-18 9:39 ` Gerd Hoffmann
2010-05-18 10:34 ` Stefano Stabellini
2010-05-18 11:20 ` Gerd Hoffmann
2010-05-18 13:02 ` Anthony Liguori
2010-05-18 22:00 ` Gerd Hoffmann
2010-05-19 12:06 ` Stefano Stabellini
2010-05-19 13:38 ` Gerd Hoffmann
2010-05-19 13:52 ` Stefano Stabellini
2010-05-19 15:22 ` Gerd Hoffmann
2010-05-19 15:30 ` Stefano Stabellini
2010-05-19 16:06 ` Julian Pidancet
2010-05-19 16:30 ` Jamie Lokier
2010-05-20 7:32 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF130BA.6050903@citrix.com \
--to=julian.pidancet@citrix.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.