[PATCH] x86, hpet: Add reference to chipset erratum documentation for disable-hpet-msi-quirk

[PATCH] x86, hpet: Add reference to chipset erratum documentation for disable-hpet-msi-quirk

[Andreas Herrmann]

From: Andreas Herrmann <andreas.herrmann3@amd.com>

(At the moment the "SB700 Family Product Errata" document is available
at http://support.amd.com/us/Embedded_TechDocs/46837.pdf)

Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
 arch/x86/kernel/quirks.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Linus recommended to add a pointer to that erratum to the source.  See

  http://marc.info/?i=alpine.LFD.2.00.1005170811400.4195@i5.linux-foundation.org

Please apply.


Thanks,

Andreas


diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
index cd2c336..e72d3fc 100644
--- a/arch/x86/kernel/quirks.c
+++ b/arch/x86/kernel/quirks.c
@@ -495,6 +495,9 @@ void force_hpet_resume(void)
 /*
  * HPET MSI on some boards (ATI SB700/SB800) has side effect on
  * floppy DMA. Disable HPET MSI on such platforms.
+ * See erratum #27 (Misinterpreted MSI Requests May Result in
+ * Corrupted LPC DMA Data) in AMD Publication #46837,
+ * "SB700 Family Product Errata", Rev. 1.0, March 2010.
  *
  * Also force the read back of the CMP register in hpet_next_event()
  * to work around the problem that the CMP register write seems to be
-- 
1.6.4.4

Re: [PATCH] x86, hpet: Add reference to chipset erratum documentation for disable-hpet-msi-quirk

[Linus Torvalds]

On Mon, 17 May 2010, Andreas Herrmann wrote:
> 
> (At the moment the "SB700 Family Product Errata" document is available
> at http://support.amd.com/us/Embedded_TechDocs/46837.pdf)

Ok, this is against x86 -tip, right? It doesn't apply for me, so I'll just 
assume I will get it through the normal x86 merge requests.

		Linus

Re: [PATCH] x86, hpet: Add reference to chipset erratum documentation for disable-hpet-msi-quirk

[H. Peter Anvin]

On 05/17/2010 09:52 AM, Linus Torvalds wrote:
> 
> 
> On Mon, 17 May 2010, Andreas Herrmann wrote:
>>
>> (At the moment the "SB700 Family Product Errata" document is available
>> at http://support.amd.com/us/Embedded_TechDocs/46837.pdf)
> 
> Ok, this is against x86 -tip, right? It doesn't apply for me, so I'll just 
> assume I will get it through the normal x86 merge requests.
> 

It conflicts with a related change in -tip, but I'll fix it up and
you'll get it with the usual merge window flood.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Re: [PATCH] x86, hpet: Add reference to chipset erratum documentation for disable-hpet-msi-quirk

[H. Peter Anvin]

On 05/17/2010 09:59 AM, H. Peter Anvin wrote:
> On 05/17/2010 09:52 AM, Linus Torvalds wrote:
>>
>>
>> On Mon, 17 May 2010, Andreas Herrmann wrote:
>>>
>>> (At the moment the "SB700 Family Product Errata" document is available
>>> at http://support.amd.com/us/Embedded_TechDocs/46837.pdf)
>>
>> Ok, this is against x86 -tip, right? It doesn't apply for me, so I'll just 
>> assume I will get it through the normal x86 merge requests.
>>
> 
> It conflicts with a related change in -tip, but I'll fix it up and
> you'll get it with the usual merge window flood.
> 

Slight correction: it didn't conflict, it was based upon.  Anyway, it's
queued up in -tip now.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

[tip:x86/timers] x86, hpet: Add reference to chipset erratum documentation for disable-hpet-msi-quirk

[tip-bot for Andreas Herrmann]

Commit-ID:  fec84e330719c20d2146c8dbdc9ff50b3a1d7039
Gitweb:     http://git.kernel.org/tip/fec84e330719c20d2146c8dbdc9ff50b3a1d7039
Author:     Andreas Herrmann <andreas.herrmann3@amd.com>
AuthorDate: Mon, 17 May 2010 18:43:24 +0200
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Mon, 17 May 2010 10:04:43 -0700

x86, hpet: Add reference to chipset erratum documentation for disable-hpet-msi-quirk

(At the moment the "SB700 Family Product Errata" document is available
at http://support.amd.com/us/Embedded_TechDocs/46837.pdf)

Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
LKML-Reference: <20100517164324.GB10254@alberich.amd.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 arch/x86/kernel/quirks.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c
index cd2c336..e72d3fc 100644
--- a/arch/x86/kernel/quirks.c
+++ b/arch/x86/kernel/quirks.c
@@ -495,6 +495,9 @@ void force_hpet_resume(void)
 /*
  * HPET MSI on some boards (ATI SB700/SB800) has side effect on
  * floppy DMA. Disable HPET MSI on such platforms.
+ * See erratum #27 (Misinterpreted MSI Requests May Result in
+ * Corrupted LPC DMA Data) in AMD Publication #46837,
+ * "SB700 Family Product Errata", Rev. 1.0, March 2010.
  *
  * Also force the read back of the CMP register in hpet_next_event()
  * to work around the problem that the CMP register write seems to be