* [PATCH 2/2] USB: s3c_hsotg: define USB_GADGET_DUALSPEED in Kconfig
@ 2010-05-17 19:12 Maurus Cuelenaere
2010-05-19 16:51 ` Maurus Cuelenaere
0 siblings, 1 reply; 2+ messages in thread
From: Maurus Cuelenaere @ 2010-05-17 19:12 UTC (permalink / raw)
To: linux-usb, linux-samsung-soc
Cc: Ben Dooks, Greg Kroah-Hartman, David Brownell
The s3c_hsotg driver sets usb_gadget->is_dualspeed to 1, yet it doesn't define
USB_GADGET_DUALSPEED in Kconfig. This triggers a NULL pointer dereference in
the composite driver (which is fixed in another patch).
Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
---
drivers/usb/gadget/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 11a3e0f..b9df8a5 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -295,6 +295,7 @@ config USB_GADGET_S3C_HSOTG
boolean "S3C HS/OtG USB Device controller"
depends on S3C_DEV_USB_HSOTG
select USB_GADGET_S3C_HSOTG_PIO
+ select USB_GADGET_DUALSPEED
help
The Samsung S3C64XX USB2.0 high-speed gadget controller
integrated into the S3C64XX series SoC.
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] USB: s3c_hsotg: define USB_GADGET_DUALSPEED in Kconfig
2010-05-17 19:12 [PATCH 2/2] USB: s3c_hsotg: define USB_GADGET_DUALSPEED in Kconfig Maurus Cuelenaere
@ 2010-05-19 16:51 ` Maurus Cuelenaere
0 siblings, 0 replies; 2+ messages in thread
From: Maurus Cuelenaere @ 2010-05-19 16:51 UTC (permalink / raw)
To: linux-usb, linux-samsung-soc
Cc: Ben Dooks, Greg Kroah-Hartman, David Brownell
Op 17-05-10 21:12, Maurus Cuelenaere schreef:
> The s3c_hsotg driver sets usb_gadget->is_dualspeed to 1, yet it doesn't define
> USB_GADGET_DUALSPEED in Kconfig. This triggers a NULL pointer dereference in
> the composite driver (which is fixed in another patch).
>
> Signed-off-by: Maurus Cuelenaere <mcuelenaere@gmail.com>
> ---
> drivers/usb/gadget/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
I'm unsure whether I should be the one stating this, but Ben acked this
patch:
Acked-by: Ben Dooks <ben-linux@fluff.org>
--
Maurus Cuelenaere
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-19 16:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-17 19:12 [PATCH 2/2] USB: s3c_hsotg: define USB_GADGET_DUALSPEED in Kconfig Maurus Cuelenaere
2010-05-19 16:51 ` Maurus Cuelenaere
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.