* [PATCH 2.6.34-rc7] HID: remove redundant key mappings from Desktop Wireless 6000
@ 2010-05-17 19:18 Don Prince
2010-05-18 8:41 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Don Prince @ 2010-05-17 19:18 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-input, linux-kernel
Remove 7 redundant key mappings from Desktop Wireless 6000 that are
already handled by the default hid code.
Signed-off-by: Don Prince <dhprince-devel@yahoo.co.uk>
---
Spotted by by Robert Schedel <r.schedel@yahoo.de>
diff -X /opt/scripts/diff-exclude.txt -Npaur a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c
--- a/drivers/hid/hid-samsung.c 2010-05-17 11:01:26.772377750 +0100
+++ b/drivers/hid/hid-samsung.c 2010-05-17 20:04:36.988502775 +0100
@@ -112,13 +112,6 @@ static int samsung_kbd_mouse_input_mappi
switch (usage->hid & HID_USAGE) {
/* report 2 */
- case 0x0b5: samsung_kbd_mouse_map_key_clear(KEY_NEXTSONG); break;
- case 0x0b6: samsung_kbd_mouse_map_key_clear(KEY_PREVIOUSSONG); break;
- case 0x0b7: samsung_kbd_mouse_map_key_clear(KEY_STOPCD); break;
- case 0x0cd: samsung_kbd_mouse_map_key_clear(KEY_PLAYPAUSE); break;
- case 0x0e2: samsung_kbd_mouse_map_key_clear(KEY_MUTE); break;
- case 0x0e9: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEUP); break;
- case 0x0ea: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEDOWN); break;
case 0x183: samsung_kbd_mouse_map_key_clear(KEY_MEDIA); break;
case 0x195: samsung_kbd_mouse_map_key_clear(KEY_EMAIL); break;
case 0x196: samsung_kbd_mouse_map_key_clear(KEY_CALC); break;
___________________________________________________________
All new Yahoo! Mail "The new Interface is stunning in its simplicity and ease of use." - PC Magazine
http://uk.docs.yahoo.com/nowyoucan.html
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 2.6.34-rc7] HID: remove redundant key mappings from Desktop Wireless 6000
2010-05-17 19:18 [PATCH 2.6.34-rc7] HID: remove redundant key mappings from Desktop Wireless 6000 Don Prince
@ 2010-05-18 8:41 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2010-05-18 8:41 UTC (permalink / raw)
To: Don Prince; +Cc: linux-input, linux-kernel
On Mon, 17 May 2010, Don Prince wrote:
> Remove 7 redundant key mappings from Desktop Wireless 6000 that are
> already handled by the default hid code.
>
> Signed-off-by: Don Prince <dhprince-devel@yahoo.co.uk>
>
> ---
>
> Spotted by by Robert Schedel <r.schedel@yahoo.de>
>
>
> diff -X /opt/scripts/diff-exclude.txt -Npaur a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c
> --- a/drivers/hid/hid-samsung.c 2010-05-17 11:01:26.772377750 +0100
> +++ b/drivers/hid/hid-samsung.c 2010-05-17 20:04:36.988502775 +0100
> @@ -112,13 +112,6 @@ static int samsung_kbd_mouse_input_mappi
>
> switch (usage->hid & HID_USAGE) {
> /* report 2 */
> - case 0x0b5: samsung_kbd_mouse_map_key_clear(KEY_NEXTSONG); break;
> - case 0x0b6: samsung_kbd_mouse_map_key_clear(KEY_PREVIOUSSONG); break;
> - case 0x0b7: samsung_kbd_mouse_map_key_clear(KEY_STOPCD); break;
> - case 0x0cd: samsung_kbd_mouse_map_key_clear(KEY_PLAYPAUSE); break;
> - case 0x0e2: samsung_kbd_mouse_map_key_clear(KEY_MUTE); break;
> - case 0x0e9: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEUP); break;
> - case 0x0ea: samsung_kbd_mouse_map_key_clear(KEY_VOLUMEDOWN); break;
Applied, thanks for spotting it Robert.
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-18 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-17 19:18 [PATCH 2.6.34-rc7] HID: remove redundant key mappings from Desktop Wireless 6000 Don Prince
2010-05-18 8:41 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.