From: Brian King <brking@linux.vnet.ibm.com>
To: Wayne Boyer <wayneb@linux.vnet.ibm.com>
Cc: James Bottomley <James.Bottomley@suse.de>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/1] ipr: set the data list length in the request control block
Date: Mon, 17 May 2010 16:19:17 -0500 [thread overview]
Message-ID: <4BF1B2D5.4020607@linux.vnet.ibm.com> (raw)
In-Reply-To: <4BED7261.6020108@linux.vnet.ibm.com>
Acked-by: Brian King <brking@linux.vnet.ibm.com>
On 05/14/2010 10:55 AM, Wayne Boyer wrote:
> In bring up testing for the new 64 bit adapters, the first read command failed
> after loading the driver. The cause was that the command requires more than
> one scatter gather element and the corresponding code to set the data list
> length in the request control block was missing. This patch adds the correct
> assignment.
>
> Signed-off-by: Wayne Boyer <wayneb@linux.vnet.ibm.com>
> ---
> drivers/scsi/ipr.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: b/drivers/scsi/ipr.c
> ===================================================================
> --- a/drivers/scsi/ipr.c 2010-05-13 12:38:47.000000000 -0700
> +++ b/drivers/scsi/ipr.c 2010-05-13 12:45:11.000000000 -0700
> @@ -5018,6 +5018,8 @@ static int ipr_build_ioadl64(struct ipr_
> ipr_cmd->dma_use_sg = nseg;
>
> ioarcb->data_transfer_length = cpu_to_be32(length);
> + ioarcb->ioadl_len =
> + cpu_to_be32(sizeof(struct ipr_ioadl64_desc) * ipr_cmd->dma_use_sg);
>
> if (scsi_cmd->sc_data_direction == DMA_TO_DEVICE) {
> ioadl_flags = IPR_IOADL_FLAGS_WRITE;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
prev parent reply other threads:[~2010-05-17 21:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100513224944.397556901@linux.vnet.ibm.com>
2010-05-14 15:55 ` [PATCH 1/1] ipr: set the data list length in the request control block Wayne Boyer
2010-05-17 21:19 ` Brian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF1B2D5.4020607@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=James.Bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=wayneb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.