* [PATCH 1/1] ipr: set the data list length in the request control block
[not found] <20100513224944.397556901@linux.vnet.ibm.com>
@ 2010-05-14 15:55 ` Wayne Boyer
2010-05-17 21:19 ` Brian King
0 siblings, 1 reply; 2+ messages in thread
From: Wayne Boyer @ 2010-05-14 15:55 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi, Brian King
In bring up testing for the new 64 bit adapters, the first read command failed
after loading the driver. The cause was that the command requires more than
one scatter gather element and the corresponding code to set the data list
length in the request control block was missing. This patch adds the correct
assignment.
Signed-off-by: Wayne Boyer <wayneb@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 2 ++
1 file changed, 2 insertions(+)
Index: b/drivers/scsi/ipr.c
===================================================================
--- a/drivers/scsi/ipr.c 2010-05-13 12:38:47.000000000 -0700
+++ b/drivers/scsi/ipr.c 2010-05-13 12:45:11.000000000 -0700
@@ -5018,6 +5018,8 @@ static int ipr_build_ioadl64(struct ipr_
ipr_cmd->dma_use_sg = nseg;
ioarcb->data_transfer_length = cpu_to_be32(length);
+ ioarcb->ioadl_len =
+ cpu_to_be32(sizeof(struct ipr_ioadl64_desc) * ipr_cmd->dma_use_sg);
if (scsi_cmd->sc_data_direction == DMA_TO_DEVICE) {
ioadl_flags = IPR_IOADL_FLAGS_WRITE;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] ipr: set the data list length in the request control block
2010-05-14 15:55 ` [PATCH 1/1] ipr: set the data list length in the request control block Wayne Boyer
@ 2010-05-17 21:19 ` Brian King
0 siblings, 0 replies; 2+ messages in thread
From: Brian King @ 2010-05-17 21:19 UTC (permalink / raw)
To: Wayne Boyer; +Cc: James Bottomley, linux-scsi
Acked-by: Brian King <brking@linux.vnet.ibm.com>
On 05/14/2010 10:55 AM, Wayne Boyer wrote:
> In bring up testing for the new 64 bit adapters, the first read command failed
> after loading the driver. The cause was that the command requires more than
> one scatter gather element and the corresponding code to set the data list
> length in the request control block was missing. This patch adds the correct
> assignment.
>
> Signed-off-by: Wayne Boyer <wayneb@linux.vnet.ibm.com>
> ---
> drivers/scsi/ipr.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: b/drivers/scsi/ipr.c
> ===================================================================
> --- a/drivers/scsi/ipr.c 2010-05-13 12:38:47.000000000 -0700
> +++ b/drivers/scsi/ipr.c 2010-05-13 12:45:11.000000000 -0700
> @@ -5018,6 +5018,8 @@ static int ipr_build_ioadl64(struct ipr_
> ipr_cmd->dma_use_sg = nseg;
>
> ioarcb->data_transfer_length = cpu_to_be32(length);
> + ioarcb->ioadl_len =
> + cpu_to_be32(sizeof(struct ipr_ioadl64_desc) * ipr_cmd->dma_use_sg);
>
> if (scsi_cmd->sc_data_direction == DMA_TO_DEVICE) {
> ioadl_flags = IPR_IOADL_FLAGS_WRITE;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-17 21:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100513224944.397556901@linux.vnet.ibm.com>
2010-05-14 15:55 ` [PATCH 1/1] ipr: set the data list length in the request control block Wayne Boyer
2010-05-17 21:19 ` Brian King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.