From: Krzysztof Foltman <wdev@foltman.com>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/1] ALSA: usb-audio: add support for Akai MPD16
Date: Tue, 18 May 2010 19:36:42 +0100 [thread overview]
Message-ID: <4BF2DE3A.20803@foltman.com> (raw)
In-Reply-To: <20100518003828.GT30801@buzzloop.caiaq.de>
On 05/18/2010 01:38 AM, Daniel Mack wrote:
> Just a minor coding style flaw here for the curly brackets. See
> Documentation/CodingStyle or let scripts/checkpatch.pl annoy you :)
Fixed, I'll resend it ASAP. The awkward part is that checkpatch.pl also
complains about the use of space after the ampersand in quirks-table.h,
where it seems to be a common practice. The CodingStyle document does
mention unary &, but it doesn't mention this sort of initialization syntax.
> FWIW, I think the block above could also be a for-loop, but that's
> certainly a matter of taste.
I wouldn't use a for statement with this longish condition - it would no
more readable than separate init/condition/increment with a while loop.
K.
next prev parent reply other threads:[~2010-05-18 18:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 22:48 [PATCH 1/1] ALSA: usb-audio: add support for Akai MPD16 wdev
2010-05-18 0:38 ` Daniel Mack
2010-05-18 18:36 ` Krzysztof Foltman [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-05-18 18:37 Krzysztof Foltman
2010-05-19 6:59 ` Clemens Ladisch
2010-05-19 20:31 ` Krzysztof Foltman
2010-05-19 20:06 Krzysztof Foltman
2010-05-20 7:26 ` Clemens Ladisch
2010-05-20 7:49 ` Krzysztof Foltman
2010-05-20 9:21 ` Clemens Ladisch
2010-05-25 9:07 ` Krzysztof Foltman
2010-05-25 9:39 ` Daniel Mack
2010-05-20 19:31 Krzysztof Foltman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF2DE3A.20803@foltman.com \
--to=wdev@foltman.com \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.