From: Clemens Ladisch <clemens@ladisch.de>
To: Krzysztof Foltman <wdev@foltman.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/1] ALSA: usb-audio: add support for Akai MPD16
Date: Thu, 20 May 2010 11:21:54 +0200 [thread overview]
Message-ID: <4BF4FF32.8080206@ladisch.de> (raw)
In-Reply-To: <4BF4E97A.9020209@foltman.com>
Krzysztof Foltman wrote:
> What about the oversized comment block about MPD16 SysEx messages -
> should it remain in the source file, or should I move it to a text file
> or remove it altogether?
The comments in this file are usually only about the protocol itself,
because this is what the driver needs to know. The fact that all
SysEx's have a known limit of 9 bytes is interesting for the driver,
but the contents of the SysEx messages are important only to programs
that want to control the MPD16; I'm not sure if this even belongs into
the kernel. (In theory, this comment belongs into that control
application.)
Regards,
Clemens
next prev parent reply other threads:[~2010-05-20 9:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 20:06 [PATCH 1/1] ALSA: usb-audio: add support for Akai MPD16 Krzysztof Foltman
2010-05-20 7:26 ` Clemens Ladisch
2010-05-20 7:49 ` Krzysztof Foltman
2010-05-20 9:21 ` Clemens Ladisch [this message]
2010-05-25 9:07 ` Krzysztof Foltman
2010-05-25 9:39 ` Daniel Mack
-- strict thread matches above, loose matches on Subject: below --
2010-05-20 19:31 Krzysztof Foltman
2010-05-18 18:37 Krzysztof Foltman
2010-05-19 6:59 ` Clemens Ladisch
2010-05-19 20:31 ` Krzysztof Foltman
2010-05-17 22:48 wdev
2010-05-18 0:38 ` Daniel Mack
2010-05-18 18:36 ` Krzysztof Foltman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF4FF32.8080206@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=wdev@foltman.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.