All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xl: recognize the "extra" entry in the domain config file
@ 2010-05-18 22:41 Jeremy Fitzhardinge
  0 siblings, 0 replies; only message in thread
From: Jeremy Fitzhardinge @ 2010-05-18 22:41 UTC (permalink / raw)
  To: Xen-devel; +Cc: Vincent Hanquez, Ian Jackson, Stefano Stabellini

"extra" defines extra parameters to be added to the kernel command line,
so append it accordingly.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

diff -r 685972a898a8 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Mon May 17 17:37:56 2010 -0700
+++ b/tools/libxl/xl_cmdimpl.c	Tue May 18 15:38:38 2010 -0700
@@ -502,14 +502,29 @@
         if (!xlu_cfg_get_long (config, "viridian", &l))
             b_info->u.hvm.viridian = l;
     } else {
-        char *cmdline;
-        if (!xlu_cfg_get_string (config, "root", &buf)) {
-            if (asprintf(&cmdline, "root=%s", buf) < 0) {
-                fprintf(stderr, "Failed to allocate memory in asprintf\n");
-                exit(1);
-            }
-            b_info->u.pv.cmdline = cmdline;
-        }
+	char *cmdline;
+	const char *root, *extra;
+
+	root = NULL;
+	extra = "";
+
+        xlu_cfg_get_string (config, "root", &root);
+        xlu_cfg_get_string (config, "extra", &extra);
+
+	cmdline = NULL;
+
+	if (root) {
+	    if (asprintf(&cmdline, "root=%s %s", root, extra) == -1)
+		cmdline = NULL;
+	} else
+	    cmdline = strdup(extra);
+
+	if ((root || extra) && !cmdline) {
+	    fprintf(stderr, "Failed to allocate memory for cmdline\n");
+	    exit(1);
+	}
+
+	b_info->u.pv.cmdline = cmdline;
         if (!xlu_cfg_get_string (config, "ramdisk", &buf))
             b_info->u.pv.ramdisk = strdup(buf);
     }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-05-18 22:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-18 22:41 [PATCH] xl: recognize the "extra" entry in the domain config file Jeremy Fitzhardinge

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.