From: Yang Hongyang <yanghy@cn.fujitsu.com>
To: Dulloor <dulloor@gmail.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] compilation and other small fixes to libxl
Date: Wed, 19 May 2010 09:40:32 +0800 [thread overview]
Message-ID: <4BF34190.1040103@cn.fujitsu.com> (raw)
In-Reply-To: <AANLkTingavs2x0ugNrh2mlEY_xTYmtUInkOenjTJYMsE@mail.gmail.com>
On 05/19/2010 09:25 AM, Dulloor wrote:
> Patch fixes the following problems :
>
> * Some of the library functions such as fscanf, system, and asprintf
> are declared with warn_unused_result (ubuntu server 9.10), causing
> compilation errors in libxl.
> * When using asprintf, the caller is responsible for freeing the memory.
> * memset takes wrong size argument in one of the places (caught by an
> a builtin gcc check).
>
> -dulloor
>
> Signed-off-by: Dulloor Rao <dulloor@gmail.com>
>
>
Acked-by: Yang Hongyang <yanghy@cn.fujitsu.com>
- domuid);
+ {
+ uptime_str = uptime_to_string(uptime, 1);
+ printf(" %s up %s, %s (%d)\n", current_time_to_string(now),
Here's an indent problem.
+ uptime_str, libxl_domid_to_name(&ctx, domuid), domuid);
+ }
else
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
--
Regards
Yang Hongyang
prev parent reply other threads:[~2010-05-19 1:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 1:25 [PATCH] compilation and other small fixes to libxl Dulloor
2010-05-19 1:40 ` Yang Hongyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF34190.1040103@cn.fujitsu.com \
--to=yanghy@cn.fujitsu.com \
--cc=dulloor@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.