[PATCH] KVM: powerpc: fix init/exit annotation

[PATCH] KVM: powerpc: fix init/exit annotation

[Jean Delvare]

kvmppc_e500_exit() is a module_exit function, so it should be tagged
with __exit, not __init. The incorrect annotation was added by commit
2986b8c72c272ea58edd37903b042c6da985627d.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Avi Kivity <avi@redhat.com>
Cc: stable@kernel.org
---
 arch/powerpc/kvm/e500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.34.orig/arch/powerpc/kvm/e500.c	2010-05-17 18:51:04.000000000 +0200
+++ linux-2.6.34/arch/powerpc/kvm/e500.c	2010-05-18 09:21:08.000000000 +0200
@@ -164,7 +164,7 @@ static int __init kvmppc_e500_init(void)
 	return kvm_init(NULL, sizeof(struct kvmppc_vcpu_e500), THIS_MODULE);
 }
 
-static void __init kvmppc_e500_exit(void)
+static void __exit kvmppc_e500_exit(void)
 {
 	kvmppc_booke_exit();
 }


-- 
Jean Delvare

RE: [PATCH] KVM: powerpc: fix init/exit annotation

[Mu Lin]

Hi, All,

Is there a status summary somewhere about Linux KVM on powerpc?

I am interested in KVM on MPC8572 with e500 core, and how about e500mc?

Is there bench mark testing results?

Thanks

Mu
________________________________________
From: kvm-ppc-owner@vger.kernel.org [kvm-ppc-owner@vger.kernel.org] On Behalf Of Jean Delvare [khali@linux-fr.org]
Sent: Tuesday, May 18, 2010 12:34 AM
To: kvm-ppc@vger.kernel.org
Cc: Stephen Rothwell; Avi Kivity
Subject: [PATCH] KVM: powerpc: fix init/exit annotation

kvmppc_e500_exit() is a module_exit function, so it should be tagged
with __exit, not __init. The incorrect annotation was added by commit
2986b8c72c272ea58edd37903b042c6da985627d.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Avi Kivity <avi@redhat.com>
Cc: stable@kernel.org
---
 arch/powerpc/kvm/e500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.34.orig/arch/powerpc/kvm/e500.c   2010-05-17 18:51:04.000000000 +0200
+++ linux-2.6.34/arch/powerpc/kvm/e500.c        2010-05-18 09:21:08.000000000 +0200
@@ -164,7 +164,7 @@ static int __init kvmppc_e500_init(void)
        return kvm_init(NULL, sizeof(struct kvmppc_vcpu_e500), THIS_MODULE);
 }

-static void __init kvmppc_e500_exit(void)
+static void __exit kvmppc_e500_exit(void)
 {
        kvmppc_booke_exit();
 }


--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] KVM: powerpc: fix init/exit annotation

[Jean Delvare]

Hi Mu,

Please don't top-post.

On Tue, 18 May 2010 00:59:20 -0700, Mu Lin wrote:
> Hi, All,
> 
> Is there a status summary somewhere about Linux KVM on powerpc?
> 
> I am interested in KVM on MPC8572 with e500 core, and how about e500mc?
> 
> Is there bench mark testing results?

Please don't hi-jack discussion threads. Your question is unrelated
with my patch, please start a new discussion thread.

-- 
Jean Delvare

Re: [PATCH] KVM: powerpc: fix init/exit annotation

[Alexander Graf]

On 18.05.2010, at 09:34, Jean Delvare wrote:

> kvmppc_e500_exit() is a module_exit function, so it should be tagged
> with __exit, not __init. The incorrect annotation was added by commit
> 2986b8c72c272ea58edd37903b042c6da985627d.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Avi Kivity <avi@redhat.com>
> Cc: stable@kernel.org

Good catch!

Signed-off-by: Alexander Graf <agraf@suse.de>


Alex

Re: [PATCH] KVM: powerpc: fix init/exit annotation

[Alexander Graf]

On 18.05.2010, at 09:34, Jean Delvare wrote:

> kvmppc_e500_exit() is a module_exit function, so it should be tagged
> with __exit, not __init. The incorrect annotation was added by commit
> 2986b8c72c272ea58edd37903b042c6da985627d.
> 
> Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
> Cc: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Cc: stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

Good catch!

Signed-off-by: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>


Alex

Re: [PATCH] KVM: powerpc: fix init/exit annotation

[Avi Kivity]

On 05/18/2010 10:34 AM, Jean Delvare wrote:
> kvmppc_e500_exit() is a module_exit function, so it should be tagged
> with __exit, not __init. The incorrect annotation was added by commit
> 2986b8c72c272ea58edd37903b042c6da985627d.
>    

Applied, thanks.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

Re: [PATCH] KVM: powerpc: fix init/exit annotation

[Jean Delvare]

Hi Avi,

On Wed, 19 May 2010 20:16:35 +0300, Avi Kivity wrote:
> On 05/18/2010 10:34 AM, Jean Delvare wrote:
> > kvmppc_e500_exit() is a module_exit function, so it should be tagged
> > with __exit, not __init. The incorrect annotation was added by commit
> > 2986b8c72c272ea58edd37903b042c6da985627d.
> 
> Applied, thanks.

Still not upstream?

-- 
Jean Delvare

Re: [PATCH] KVM: powerpc: fix init/exit annotation

[Avi Kivity]

On 06/06/2010 02:03 PM, Jean Delvare wrote:
> Hi Avi,
>
> On Wed, 19 May 2010 20:16:35 +0300, Avi Kivity wrote:
>    
>> On 05/18/2010 10:34 AM, Jean Delvare wrote:
>>      
>>> kvmppc_e500_exit() is a module_exit function, so it should be tagged
>>> with __exit, not __init. The incorrect annotation was added by commit
>>> 2986b8c72c272ea58edd37903b042c6da985627d.
>>>        
>> Applied, thanks.
>>      
> Still not upstream?
>    

It's queued, will get there within a few days.


-- 
error compiling committee.c: too many arguments to function