Documentation/spi/* compile warning fix

Documentation/spi/* compile warning fix

[Prarit Bhargava]

Fix this warning:

Documentation/spi/spidev_fdx.c: In function `do_msg':
Documentation/spi/spidev_fdx.c:61: warning: cast from pointer to integer of different size
Documentation/spi/spidev_fdx.c:64: warning: cast from pointer to integer of different size

buf should be unsigned long to match native arch on 32-bit x86 compile.

Signed-off-by: Prarit Bhargava <prarit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

diff --git a/Documentation/spi/spidev_fdx.c b/Documentation/spi/spidev_fdx.c
index fc354f7..36ec077 100644
--- a/Documentation/spi/spidev_fdx.c
+++ b/Documentation/spi/spidev_fdx.c
@@ -58,10 +58,10 @@ static void do_msg(int fd, int len)
 		len = sizeof buf;
 
 	buf[0] = 0xaa;
-	xfer[0].tx_buf = (__u64) buf;
+	xfer[0].tx_buf = (unsigned long)buf;
 	xfer[0].len = 1;
 
-	xfer[1].rx_buf = (__u64) buf;
+	xfer[1].rx_buf = (unsigned long) buf;
 	xfer[1].len = len;
 
 	status = ioctl(fd, SPI_IOC_MESSAGE(2), xfer);

------------------------------------------------------------------------------

Re: Documentation/spi/* compile warning fix

[Prarit Bhargava]

Sorry everyone ... I left off [PATCH]: ... will resend shortly.

(And then I top-posted too...)

P.

On 05/19/2010 02:01 PM, Prarit Bhargava wrote:
> Fix this warning:
>
> Documentation/spi/spidev_fdx.c: In function `do_msg':
> Documentation/spi/spidev_fdx.c:61: warning: cast from pointer to integer of different size
> Documentation/spi/spidev_fdx.c:64: warning: cast from pointer to integer of different size
>
> buf should be unsigned long to match native arch on 32-bit x86 compile.
>
> Signed-off-by: Prarit Bhargava<prarit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/Documentation/spi/spidev_fdx.c b/Documentation/spi/spidev_fdx.c
> index fc354f7..36ec077 100644
> --- a/Documentation/spi/spidev_fdx.c
> +++ b/Documentation/spi/spidev_fdx.c
> @@ -58,10 +58,10 @@ static void do_msg(int fd, int len)
>   		len = sizeof buf;
>
>   	buf[0] = 0xaa;
> -	xfer[0].tx_buf = (__u64) buf;
> +	xfer[0].tx_buf = (unsigned long)buf;
>   	xfer[0].len = 1;
>
> -	xfer[1].rx_buf = (__u64) buf;
> +	xfer[1].rx_buf = (unsigned long) buf;
>   	xfer[1].len = len;
>
>   	status = ioctl(fd, SPI_IOC_MESSAGE(2), xfer);
>    

------------------------------------------------------------------------------

Re: Documentation/spi/* compile warning fix

[Grant Likely]

On Wed, May 19, 2010 at 1:25 PM, Prarit Bhargava <prarit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Sorry everyone ... I left off [PATCH]: ... will resend shortly.
>
> (And then I top-posted too...)

[PATCH] is trivial and unnecessary.  As long as it shows up in
patchwork, then I won't forget about it:

https://patchwork.kernel.org/patch/100984/

(It may take me a while to pick it up, but I won't forget about it).

g.

------------------------------------------------------------------------------