All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takahiro Yasui <tyasui@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] handle transient errors in lvconvert --repair
Date: Wed, 19 May 2010 15:46:05 -0400	[thread overview]
Message-ID: <4BF43FFD.30504@redhat.com> (raw)
In-Reply-To: <874oi34ubd.fsf@twilight.int.mornfall.net.>

Hi Petr,

>+++ cvs-upstream/tools/lvconvert.c	2010-05-19 20:18:40.000000000 +0200
>@@ -1225,11 +1225,11 @@
> 		if (!lv_remove_mirrors(cmd, lv, failed_mirrors, new_log_count,
> 				       _is_partial_lv, NULL, 0))
> 			return 0;

As I posted in the previous mail, the argument, new_log_count, is
correct here? The argument is used to check if a log should be removed.
I think that failed_log comes here instead of new_log_count.
Or the value such as nlc in _lvconvert_mirrors_aux() comes.

                uint32_t nlc = (!new_log_count || lp->mirrors == 1) ? 1U : 0U;
		...
		} else if (!lv_remove_mirrors(cmd, lv, nmc, nlc,
                                              is_mirror_image_removable, operable_pvs, 0))


Thanks,
Taka



  reply	other threads:[~2010-05-19 19:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27 15:14 [PATCH] handle transient errors in lvconvert --repair Petr Rockai
2010-04-27 18:03 ` Petr Rockai
2010-05-06 17:30   ` Petr Rockai
2010-05-14 22:52     ` Takahiro Yasui
2010-05-17 23:01       ` Takahiro Yasui
2010-05-19 12:06         ` Petr Rockai
2010-05-19 15:06           ` Takahiro Yasui
2010-05-19 18:31             ` Petr Rockai
2010-05-19 19:46               ` Takahiro Yasui [this message]
2010-05-19 20:19                 ` Petr Rockai
2010-05-19 20:31                   ` Alasdair G Kergon
2010-05-19 20:35                   ` Takahiro Yasui
2010-05-20  0:49               ` Takahiro Yasui
2010-05-20  7:40                 ` Petr Rockai
2010-05-20 11:54                   ` Takahiro Yasui
2010-05-19 16:44           ` Takahiro Yasui
2010-05-19 17:15             ` Takahiro Yasui
2010-05-19 20:26               ` Petr Rockai
2010-04-28 19:37 ` Takahiro Yasui
2010-05-05  7:46   ` Petr Rockai
2010-05-05 15:31     ` Takahiro Yasui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF43FFD.30504@redhat.com \
    --to=tyasui@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.