All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare
Date: Thu, 20 May 2010 10:50:38 +0200	[thread overview]
Message-ID: <4BF4F7DE.7060308@redhat.com> (raw)
In-Reply-To: <20100519185309.GA27591@lst.de>

Am 19.05.2010 20:53, schrieb Christoph Hellwig:
> The difference between the start sectors of two requests can be larger
> than the size of the "int" type, which can lead to a not correctly
> sorted multiwrite array and thus spurious I/O errors and filesystem
> corruption due to incorrect request merges.
> 
> So instead of doing the cute sector arithmetics trick spell out the
> exact comparisms.
> 
> Spotted by Kevin Wolf based on a testcase from Michael Tokarev.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Thanks, applied to the block branch.

Kevin

      parent reply	other threads:[~2010-05-20  8:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19 18:53 [Qemu-devel] [PATCH] block: fix sector comparism in multiwrite_req_compare Christoph Hellwig
2010-05-19 19:26 ` [Qemu-devel] " Michael Tokarev
2010-05-19 19:38   ` Christoph Hellwig
2010-05-19 19:42     ` Michael Tokarev
2010-05-19 21:09       ` Kevin Wolf
2010-05-20  6:09         ` Avi Kivity
2010-05-20  8:19           ` Kevin Wolf
2010-05-20  8:30             ` Avi Kivity
2010-05-20  8:50 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF4F7DE.7060308@redhat.com \
    --to=kwolf@redhat.com \
    --cc=hch@lst.de \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.