From: Michael Tokarev <mjt@tls.msk.ru>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] block: fix sector comparism in multiwrite_req_compare
Date: Wed, 19 May 2010 23:42:40 +0400 [thread overview]
Message-ID: <4BF43F30.4050109@msgid.tls.msk.ru> (raw)
In-Reply-To: <20100519193802.GA29104@lst.de>
19.05.2010 23:38, Christoph Hellwig wrote:
> On Wed, May 19, 2010 at 11:26:58PM +0400, Michael Tokarev wrote:
>> Now the question is if the previous patch by Avi is actually
>> worth to apply -- I mean this one:
>> [Qemu-devel] [PATCH +stable] block: don't attempt to merge overlapping
>> requests
>
> No, that was just a hack, it shouldn't be applied.
Actually it's not that obvious. If the actual problem
here (besides the mis-comparison) is due to missing
barriers or flushes. Avi asked a good question in that
thread.
But I'm hijacking the thread actually :)
/mjt
next prev parent reply other threads:[~2010-05-19 19:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 18:53 [Qemu-devel] [PATCH] block: fix sector comparism in multiwrite_req_compare Christoph Hellwig
2010-05-19 19:26 ` [Qemu-devel] " Michael Tokarev
2010-05-19 19:38 ` Christoph Hellwig
2010-05-19 19:42 ` Michael Tokarev [this message]
2010-05-19 21:09 ` Kevin Wolf
2010-05-20 6:09 ` Avi Kivity
2010-05-20 8:19 ` Kevin Wolf
2010-05-20 8:30 ` Avi Kivity
2010-05-20 8:50 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF43F30.4050109@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=avi@redhat.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.