All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockrwd@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jeff Garzik <jeff@garzik.org>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	Kay Sievers <kay.sievers@vrfy.org>,
	Nick Bowler <nbowler@elliptictech.com>,
	David Zeuthen <david@fubar.dk>,
	linux-hotplug@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH #upstream-fixes] libata: disable ATAPI AN by default
Date: Fri, 21 May 2010 04:49:33 +0000	[thread overview]
Message-ID: <4BF610DD.20502@gmail.com> (raw)
In-Reply-To: <4BF4177B.2040108@kernel.org>

On 05/19/2010 10:53 AM, Tejun Heo wrote:
> Hello,
>
> On 05/19/2010 06:14 PM, Jeff Garzik wrote:
>> Windows completely disables AN?
>>
>> Or do we simply need to be less naive about _delivery_ of AN's?
>
> I think we first need to verify what the event is about before
> delivering it to userland; IOW, it should kick a full polling op.  The
> problem is the same with periodic polling.  Windows does it with
> single command but we can't do that from userland as open() involves
> issuing more commands.  That discrepancy is basically we're having all
> these problems with periodic polling and AN infinite looping.
>
> Hardware vendors don't consider cases where their devices are hit with
> a series of commands periodically or after raising an AN event.  We
> have quite a few drives which just die after being hit repeatedly with
> media presence polling commands and this one is causing infinite loop
> by re-raising AN.
>
> So, until we can replicate the windows behavior (which actually is
> pretty reasonable - just use single GET_CONFIGURATION call for polling
> and status check), I think it's wiser to disable AN.

There are also some drives where AN is just broken - I have a Lite-ON 
DH-401S BD-ROM drive which raises AN on opening the tray, but not on 
closing with media inserted.

I don't know if Windows is using AN at all yet or not. Seems like a lot 
of drives aren't tested well with it though.

WARNING: multiple messages have this Message-ID (diff)
From: Robert Hancock <hancockrwd@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jeff Garzik <jeff@garzik.org>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	Kay Sievers <kay.sievers@vrfy.org>,
	Nick Bowler <nbowler@elliptictech.com>,
	David Zeuthen <david@fubar.dk>,
	linux-hotplug@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH #upstream-fixes] libata: disable ATAPI AN by default
Date: Thu, 20 May 2010 22:49:33 -0600	[thread overview]
Message-ID: <4BF610DD.20502@gmail.com> (raw)
In-Reply-To: <4BF4177B.2040108@kernel.org>

On 05/19/2010 10:53 AM, Tejun Heo wrote:
> Hello,
>
> On 05/19/2010 06:14 PM, Jeff Garzik wrote:
>> Windows completely disables AN?
>>
>> Or do we simply need to be less naive about _delivery_ of AN's?
>
> I think we first need to verify what the event is about before
> delivering it to userland; IOW, it should kick a full polling op.  The
> problem is the same with periodic polling.  Windows does it with
> single command but we can't do that from userland as open() involves
> issuing more commands.  That discrepancy is basically we're having all
> these problems with periodic polling and AN infinite looping.
>
> Hardware vendors don't consider cases where their devices are hit with
> a series of commands periodically or after raising an AN event.  We
> have quite a few drives which just die after being hit repeatedly with
> media presence polling commands and this one is causing infinite loop
> by re-raising AN.
>
> So, until we can replicate the windows behavior (which actually is
> pretty reasonable - just use single GET_CONFIGURATION call for polling
> and status check), I think it's wiser to disable AN.

There are also some drives where AN is just broken - I have a Lite-ON 
DH-401S BD-ROM drive which raises AN on opening the tray, but not on 
closing with media inserted.

I don't know if Windows is using AN at all yet or not. Seems like a lot 
of drives aren't tested well with it though.

  reply	other threads:[~2010-05-21  4:49 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13 15:30 udev cdrom_id rules prevent unmounted CD from spinning down Nick Bowler
2010-05-13 16:27 ` Marco d'Itri
2010-05-13 20:13 ` Nick Bowler
2010-05-13 21:27 ` Kay Sievers
2010-05-13 21:37 ` Nick Bowler
2010-05-14  7:36 ` Martin Pitt
2010-05-14 13:51 ` Nick Bowler
2010-05-14 14:41 ` Kay Sievers
2010-05-14 18:48 ` Nick Bowler
2010-05-17 10:06 ` Kay Sievers
2010-05-17 12:43 ` Nick Bowler
2010-05-17 16:27 ` Kay Sievers
2010-05-17 22:54 ` Nicolas Thomas Bowler
2010-05-18  5:08 ` Kay Sievers
2010-05-18 13:25 ` Nick Bowler
2010-05-18 14:21 ` Kay Sievers
2010-05-18 16:23 ` Nick Bowler
2010-05-18 17:53 ` Kay Sievers
2010-05-18 18:14 ` Tejun Heo
2010-05-18 18:20 ` Kay Sievers
2010-05-18 18:28 ` Tejun Heo
2010-05-18 18:53 ` Kay Sievers
2010-05-18 19:23 ` Nick Bowler
2010-05-18 20:18 ` Kay Sievers
2010-05-19 13:23 ` Tejun Heo
2010-05-19 13:38   ` [PATCH #upstream-fixes] libata: disable ATAPI AN by default Tejun Heo
2010-05-19 13:38     ` Tejun Heo
2010-05-19 16:14     ` Jeff Garzik
2010-05-19 16:14       ` Jeff Garzik
2010-05-19 16:53       ` Tejun Heo
2010-05-19 16:53         ` Tejun Heo
2010-05-21  4:49         ` Robert Hancock [this message]
2010-05-21  4:49           ` Robert Hancock
2010-05-19 16:58     ` Nick Bowler
2010-05-19 16:58       ` Nick Bowler
2010-05-25 23:41     ` Jeff Garzik
2010-05-25 23:41       ` Jeff Garzik
2010-05-19 13:55 ` udev cdrom_id rules prevent unmounted CD from spinning down Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF610DD.20502@gmail.com \
    --to=hancockrwd@gmail.com \
    --cc=david@fubar.dk \
    --cc=jeff@garzik.org \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-hotplug@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=nbowler@elliptictech.com \
    --cc=stable@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.