From: Kevin Wolf <kwolf@redhat.com>
To: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Cc: hch@lst.de, qemu-devel@nongnu.org, kvm@vger.kernel.org,
sheepdog@lists.wpkg.org
Subject: Re: [PATCH] add support for protocol driver create_options
Date: Fri, 21 May 2010 13:40:31 +0200 [thread overview]
Message-ID: <4BF6712F.5060300@redhat.com> (raw)
In-Reply-To: <1274333777-15415-1-git-send-email-morita.kazutaka@lab.ntt.co.jp>
Am 20.05.2010 07:36, schrieb MORITA Kazutaka:
> This patch enables protocol drivers to use their create options which
> are not supported by the format. For example, protcol drivers can use
> a backing_file option with raw format.
>
> Signed-off-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Hm, this is not stackable, right? Though I do see that making it
stackable would require some bigger changes, so maybe we can get away
with claiming that this approach covers everything that happens in practice.
If we accept that this is the desired behaviour, the code looks good to me.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Cc: sheepdog@lists.wpkg.org, hch@lst.de, kvm@vger.kernel.org,
qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] add support for protocol driver create_options
Date: Fri, 21 May 2010 13:40:31 +0200 [thread overview]
Message-ID: <4BF6712F.5060300@redhat.com> (raw)
In-Reply-To: <1274333777-15415-1-git-send-email-morita.kazutaka@lab.ntt.co.jp>
Am 20.05.2010 07:36, schrieb MORITA Kazutaka:
> This patch enables protocol drivers to use their create options which
> are not supported by the format. For example, protcol drivers can use
> a backing_file option with raw format.
>
> Signed-off-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Hm, this is not stackable, right? Though I do see that making it
stackable would require some bigger changes, so maybe we can get away
with claiming that this approach covers everything that happens in practice.
If we accept that this is the desired behaviour, the code looks good to me.
Kevin
next prev parent reply other threads:[~2010-05-21 11:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 5:36 [PATCH] add support for protocol driver create_options MORITA Kazutaka
2010-05-20 5:36 ` [Qemu-devel] " MORITA Kazutaka
2010-05-20 5:40 ` Kvm device passthrough Mu Lin
2010-05-20 5:40 ` [Qemu-devel] " Mu Lin
2010-05-21 11:40 ` Kevin Wolf [this message]
2010-05-21 11:40 ` [Qemu-devel] Re: [PATCH] add support for protocol driver create_options Kevin Wolf
[not found] ` <4BF6712F.5060300-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-05-24 6:21 ` MORITA Kazutaka
2010-05-24 6:21 ` [Qemu-devel] " MORITA Kazutaka
[not found] ` <1274333777-15415-1-git-send-email-morita.kazutaka-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2010-05-21 16:57 ` Kevin Wolf
2010-05-21 16:57 ` [Qemu-devel] " Kevin Wolf
[not found] ` <4BF6BB80.1060504-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-05-24 6:34 ` MORITA Kazutaka
2010-05-24 6:34 ` [Qemu-devel] " MORITA Kazutaka
2010-05-25 13:43 ` Kevin Wolf
2010-05-25 13:43 ` [Qemu-devel] " Kevin Wolf
[not found] ` <4BFBD3F5.5020805-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-05-26 2:35 ` MORITA Kazutaka
2010-05-26 2:35 ` [Qemu-devel] " MORITA Kazutaka
2010-05-26 9:02 ` Kevin Wolf
2010-05-26 9:02 ` [Qemu-devel] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF6712F.5060300@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=morita.kazutaka@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
--cc=sheepdog@lists.wpkg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.